| Message ID | 20200919031702.32192-1-jingxiangfeng@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a7597a9515a27cc49229940add082ebb37ea9e90 |
| Headers | show |
| Series | xen: remove redundant initialization of variable ret | expand |
On 19.09.20 05:17, Jing Xiangfeng wrote: > After commit 9f51c05dc41a ("pvcalls-front: Avoid > get_free_pages(GFP_KERNEL) under spinlock"), the variable ret is being > initialized with '-ENOMEM' that is meaningless. So remove it. > > Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com> Reviewed-by: Juergen Gross <jgross@suse.com> Juergen
On 9/18/20 11:17 PM, Jing Xiangfeng wrote: > After commit 9f51c05dc41a ("pvcalls-front: Avoid > get_free_pages(GFP_KERNEL) under spinlock"), the variable ret is being > initialized with '-ENOMEM' that is meaningless. So remove it. > > Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com> Applied to for-linus-5.10 -boris
diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c index 72d725a0ab5c..7984645b5956 100644 --- a/drivers/xen/pvcalls-front.c +++ b/drivers/xen/pvcalls-front.c @@ -371,7 +371,7 @@ static int alloc_active_ring(struct sock_mapping *map) static int create_active(struct sock_mapping *map, evtchn_port_t *evtchn) { void *bytes; - int ret = -ENOMEM, irq = -1, i; + int ret, irq = -1, i; *evtchn = 0; init_waitqueue_head(&map->active.inflight_conn_req);
After commit 9f51c05dc41a ("pvcalls-front: Avoid get_free_pages(GFP_KERNEL) under spinlock"), the variable ret is being initialized with '-ENOMEM' that is meaningless. So remove it. Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com> --- drivers/xen/pvcalls-front.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)