diff mbox series

[OSSTEST,50/82] shared/reuse: Rely on @ for ts-host-ping-check

Message ID 20201007180024.7932-51-iwj@xenproject.org (mailing list archive)
State New, archived
Headers show
Series Reuse test hosts | expand

Commit Message

Ian Jackson Oct. 7, 2020, 5:59 p.m. UTC 
From: Ian Jackson <ian.jackson@eu.citrix.com>

Remove the check for SharedReady.

The existence of this check is perplexing.  It was introduced in
  ts-host-ping-check: Do not run if host is being reused
in 8f1dc3f7c401 (from 2015).

At that time we only share build hosts, and build hosts never ran this
script.  So I don't understand what that was hoping to achieve.  Maybe
it made some difference in a now-lost pre-rebase situation.

Anyway, in our current tree I think we want to rerun the
ts-host-ping-check when we reuse a test host.  My change to add @ to
parts of per-host-prep in sg-run-job deliberately omitted the step
with testid host-ping-check-xen/@.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
 ts-host-ping-check | 2 --
 1 file changed, 2 deletions(-)
diff mbox series

Patch

diff --git a/ts-host-ping-check b/ts-host-ping-check
index a670680c..512aaec3 100755
--- a/ts-host-ping-check
+++ b/ts-host-ping-check
@@ -27,8 +27,6 @@  our ($whhost) = @ARGV;
 $whhost ||= 'host';
 our $ho= selecthost($whhost);
 
-exit 0 if $ho->{SharedReady};
-
 $_ = `ping -D -i 0.2 -c 100 $ho->{Ip} | tee -a /dev/stderr`;
 
 m/\b([0-9.]+)% packet loss\b/ or die "$_ ?";