From patchwork Thu Oct 15 15:50:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Jackson X-Patchwork-Id: 11839567 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 539241580 for ; Thu, 15 Oct 2020 15:51:44 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C24722254 for ; Thu, 15 Oct 2020 15:51:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=xenproject.org header.i=@xenproject.org header.b="Q/8ZYg2r" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C24722254 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=xenproject.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.7515.19654 (Exim 4.92) (envelope-from ) id 1kT5WR-0006H6-0V; Thu, 15 Oct 2020 15:50:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 7515.19654; Thu, 15 Oct 2020 15:50:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kT5WQ-0006Gu-OB; Thu, 15 Oct 2020 15:50:30 +0000 Received: by outflank-mailman (input) for mailman id 7515; Thu, 15 Oct 2020 15:50:30 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kT5WP-0006GR-Ub for xen-devel@lists.xenproject.org; Thu, 15 Oct 2020 15:50:29 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8c9d18f5-3706-4452-bb2e-3b894d5a3882; Thu, 15 Oct 2020 15:50:29 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kT5WO-00087r-QW for xen-devel@lists.xenproject.org; Thu, 15 Oct 2020 15:50:28 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kT5WO-0005Ey-Oo for xen-devel@lists.xenproject.org; Thu, 15 Oct 2020 15:50:28 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kT5WN-0000oB-0F; Thu, 15 Oct 2020 16:50:27 +0100 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kT5WP-0006GR-Ub for xen-devel@lists.xenproject.org; Thu, 15 Oct 2020 15:50:29 +0000 X-Inumbo-ID: 8c9d18f5-3706-4452-bb2e-3b894d5a3882 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8c9d18f5-3706-4452-bb2e-3b894d5a3882; Thu, 15 Oct 2020 15:50:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=GKNUYQeiTTAK8ez/vVJcZ2hoW8Ug+I9meJLpgJqBeIU=; b=Q/8ZYg2rwXY9YNgyMWTqtdK71s Hnuv+uKXW4Y5/kNa24G4vbTHCC4kUxl0kAcWsbflvzZG+PKjMMND9O8uijMOaUI0WHyZEgdRDbgkK 7r9RQqayc3e1qLH40ULry3k2bNV2W+sHp68N9Rp1NsMFipf4vagcjcVua7bKdRxT4WoI=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kT5WO-00087r-QW for xen-devel@lists.xenproject.org; Thu, 15 Oct 2020 15:50:28 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kT5WO-0005Ey-Oo for xen-devel@lists.xenproject.org; Thu, 15 Oct 2020 15:50:28 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kT5WN-0000oB-0F; Thu, 15 Oct 2020 16:50:27 +0100 From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: Ian Jackson Subject: [OSSTEST PATCH v2 03/17] sg-report-flight: Consider all blessings for "never pass" Date: Thu, 15 Oct 2020 16:50:05 +0100 Message-Id: <20201015155019.20705-4-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201015155019.20705-1-iwj@xenproject.org> References: <20201015155019.20705-1-iwj@xenproject.org> MIME-Version: 1.0 $anypassq is used for the "never pass" check; the distinction between this and simply "fail" is cosmetic (although it can be informative). On non-"real" flights, it can easily happen that the flight never passed *on this branch with this blessing* but has passed on real. So the steps subquery does not find us an answer within reasonable time. Work around this by always searching for "real". This keeps the performance within acceptable bounds even during ad-hoc testing. We don't actually use the row from this query, so the only effect is that when the job passed in a "real" flight, we go on to the full regresson analysis rather than short-circuiting and reporting "never pass". Signed-off-by: Ian Jackson --- sg-report-flight | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sg-report-flight b/sg-report-flight index a07e03cb..15631001 100755 --- a/sg-report-flight +++ b/sg-report-flight @@ -935,7 +935,7 @@ sub justifyfailures ($;$) { ) SELECT * FROM flights JOIN s USING (flight) WHERE $branches_cond_q - AND $blessingscond + AND ($blessingscond) OR blessing = 'real' LIMIT 1 END $anypassq= db_prepare($anypassq);