From patchwork Thu Oct 22 16:45:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Jackson X-Patchwork-Id: 11851629 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0E0A91865 for ; Thu, 22 Oct 2020 17:09:42 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C5E8E24630 for ; Thu, 22 Oct 2020 17:09:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=xenproject.org header.i=@xenproject.org header.b="oNAJn4Nb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C5E8E24630 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=xenproject.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.10597.28264 (Exim 4.92) (envelope-from ) id 1kVe5Q-0002KN-1o; Thu, 22 Oct 2020 17:09:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 10597.28264; Thu, 22 Oct 2020 17:09:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5P-0002KF-UN; Thu, 22 Oct 2020 17:09:11 +0000 Received: by outflank-mailman (input) for mailman id 10597; Thu, 22 Oct 2020 17:09:09 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5N-0002GB-Ok for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:09 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 586d40d2-9e6f-43e5-8ea2-2722e0efbe36; Thu, 22 Oct 2020 17:09:08 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5M-0005tU-Hj for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:08 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVe5M-0005W0-Gu for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:08 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiH-00059e-Cj; Thu, 22 Oct 2020 17:45:17 +0100 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5N-0002GB-Ok for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:09 +0000 X-Inumbo-ID: 586d40d2-9e6f-43e5-8ea2-2722e0efbe36 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 586d40d2-9e6f-43e5-8ea2-2722e0efbe36; Thu, 22 Oct 2020 17:09:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=uD3SLBKiMkKsr66Riht6zcwv/GQ882j78TtfYVzfoKE=; b=oNAJn4NbsakzNZDpST6aDvIwWy v3eFTy0uKSG6l3lsKn9PaVP0iLv3a+ssXfkNGpg6todEHlxijFZq9YSge1+0xH9F7OWgo4fCK60fQ ZwDecxOiN6ZVdbJ7vQ/7eLWwa6TwOTrGBKi3zNGiyHQa4KkhqK2nOvMyBmuITB/9Tivs=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5M-0005tU-Hj for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:08 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVe5M-0005W0-Gu for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:08 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiH-00059e-Cj; Thu, 22 Oct 2020 17:45:17 +0100 From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: Ian Jackson Subject: [OSSTEST PATCH 15/16] host reuse fixes: Do not break host-reuse if no host allocated Date: Thu, 22 Oct 2020 17:45:05 +0100 Message-Id: <20201022164506.1552-16-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201022164506.1552-1-iwj@xenproject.org> References: <20201022164506.1552-1-iwj@xenproject.org> MIME-Version: 1.0 If host allocation failed, or our dependency jobs failed, then we won't have allocated a host. The host runvar will not be set. In this case, we want to do nothing. But we forgot to pass $noneok to selecthost. Signed-off-by: Ian Jackson --- ts-host-reuse | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ts-host-reuse b/ts-host-reuse index e2498bb6..b885a3e6 100755 --- a/ts-host-reuse +++ b/ts-host-reuse @@ -165,7 +165,7 @@ sub act_start_test () { sub act_final () { if (!@ARGV) { - $ho = selecthost($whhost); + $ho = selecthost($whhost, 1); return unless $ho; host_update_lifecycle_info($ho, 'final'); } elsif ("@ARGV" eq "--post-test-ok") {