From patchwork Thu Oct 22 16:44:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Jackson X-Patchwork-Id: 11851605 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4F90792C for ; Thu, 22 Oct 2020 16:46:07 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 13F0822267 for ; Thu, 22 Oct 2020 16:46:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=xenproject.org header.i=@xenproject.org header.b="p4+G4XG0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 13F0822267 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=xenproject.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.10558.28093 (Exim 4.92) (envelope-from ) id 1kVdiJ-0007JL-KX; Thu, 22 Oct 2020 16:45:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 10558.28093; Thu, 22 Oct 2020 16:45:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiJ-0007JE-HK; Thu, 22 Oct 2020 16:45:19 +0000 Received: by outflank-mailman (input) for mailman id 10558; Thu, 22 Oct 2020 16:45:17 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiH-0007J4-LK for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:17 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 61030cba-ae82-48ad-b164-aef21b3733e6; Thu, 22 Oct 2020 16:45:16 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiG-0005KI-3b for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:16 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVdiG-0007RI-2W for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:16 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiE-00059e-Aq; Thu, 22 Oct 2020 17:45:14 +0100 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiH-0007J4-LK for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:17 +0000 X-Inumbo-ID: 61030cba-ae82-48ad-b164-aef21b3733e6 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 61030cba-ae82-48ad-b164-aef21b3733e6; Thu, 22 Oct 2020 16:45:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=VA0MrPoomWT3D4MkBrEL/LD+ZtLasw0letLMtdwmVoo=; b=p4+G4XG0pUFpbh94MGkdGu02z5 WqnNdxe2RlLXu9VjaAGH2FXurQYatuo4cFX0LN8VOud5EL04EqVLbgzy2N+JYEAvZMMm9GVlEw5NJ lJNBqLCrTaMXAascAik3c1Cwr34TLJDtSlpopt+Eq0WptgWNnUss9FjtoBlaN+be3ovI=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiG-0005KI-3b for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:16 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVdiG-0007RI-2W for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:16 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiE-00059e-Aq; Thu, 22 Oct 2020 17:45:14 +0100 From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: Ian Jackson Subject: [OSSTEST PATCH 03/16] PDU/IPMI: Retransmit, don't just wait Date: Thu, 22 Oct 2020 17:44:53 +0100 Message-Id: <20201022164506.1552-4-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201022164506.1552-1-iwj@xenproject.org> References: <20201022164506.1552-1-iwj@xenproject.org> MIME-Version: 1.0 We have a system for which ipmitool -H sabro0m -U root -P XXXX -I lanplus power on seems to work but doesn't take effect the first time. Retransit each retry. Signed-off-by: Ian Jackson --- Osstest/PDU/ipmi.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Osstest/PDU/ipmi.pm b/Osstest/PDU/ipmi.pm index 98e8957f..21c94d98 100644 --- a/Osstest/PDU/ipmi.pm +++ b/Osstest/PDU/ipmi.pm @@ -66,11 +66,12 @@ sub pdu_power_state { return; } - system_checked((@cmd, qw(power), $onoff)); - my $count = 60; for (;;) { last if $getstatus->() eq $onoff; + + system_checked((@cmd, qw(power), $onoff)); + die "did not power $onoff" unless --$count > 0; sleep(1); }