| Message ID | 20201104090610.1446616-9-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Rid W=1 warnings in Net | expand |
On 04.11.20 10:06, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/xen-netfront.c: In function ‘store_rxbuf’: > drivers/net/xen-netfront.c:2416:16: warning: variable ‘target’ set but not used [-Wunused-but-set-variable] Those two warnings are not fixed by the patch. > drivers/net/xen-netfront.c:1592: warning: Function parameter or member 'dev' not described in 'netfront_probe' > drivers/net/xen-netfront.c:1592: warning: Function parameter or member 'id' not described in 'netfront_probe' > drivers/net/xen-netfront.c:1669: warning: Function parameter or member 'dev' not described in 'netfront_resume' > drivers/net/xen-netfront.c:2313: warning: Function parameter or member 'dev' not described in 'netback_changed' > drivers/net/xen-netfront.c:2313: warning: Function parameter or member 'backend_state' not described in 'netback_changed' > > Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> > Cc: Juergen Gross <jgross@suse.com> > Cc: Stefano Stabellini <sstabellini@kernel.org> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Alexei Starovoitov <ast@kernel.org> > Cc: Daniel Borkmann <daniel@iogearbox.net> > Cc: Jesper Dangaard Brouer <hawk@kernel.org> > Cc: John Fastabend <john.fastabend@gmail.com> > Cc: Martin KaFai Lau <kafai@fb.com> > Cc: Song Liu <songliubraving@fb.com> > Cc: Yonghong Song <yhs@fb.com> > Cc: Andrii Nakryiko <andrii@kernel.org> > Cc: KP Singh <kpsingh@chromium.org> > Cc: xen-devel@lists.xenproject.org > Cc: netdev@vger.kernel.org > Cc: bpf@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> With the commit message fixed you can have my: Reviewed-by: Juergen Gross <jgross@suse.com> Juergen
On Wed, Nov 04, 2020 at 09:06:06AM +0000, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/xen-netfront.c: In function ‘store_rxbuf’: > drivers/net/xen-netfront.c:2416:16: warning: variable ‘target’ set but not used [-Wunused-but-set-variable] > drivers/net/xen-netfront.c:1592: warning: Function parameter or member 'dev' not described in 'netfront_probe' > drivers/net/xen-netfront.c:1592: warning: Function parameter or member 'id' not described in 'netfront_probe' > drivers/net/xen-netfront.c:1669: warning: Function parameter or member 'dev' not described in 'netfront_resume' > drivers/net/xen-netfront.c:2313: warning: Function parameter or member 'dev' not described in 'netback_changed' > drivers/net/xen-netfront.c:2313: warning: Function parameter or member 'backend_state' not described in 'netback_changed' > commit 8ed7ec1386b646130d80d017ecd4716f866ea570 Author: Andrew Lunn <andrew@lunn.ch> Date: Sat Oct 31 19:04:35 2020 +0100 drivers: net: xen-netfront: Fixed W=1 set but unused warnings Already in net-next. Andrew
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index 920cac4385bf7..93740ef4cf1b4 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers/net/xen-netfront.c @@ -1582,7 +1582,7 @@ static struct net_device *xennet_create_dev(struct xenbus_device *dev) return ERR_PTR(err); } -/** +/* * Entry point to this code when a new device is created. Allocate the basic * structures and the ring buffers for communication with the backend, and * inform the backend of the appropriate details for those. @@ -1659,7 +1659,7 @@ static void xennet_disconnect_backend(struct netfront_info *info) } } -/** +/* * We are reconnecting to the backend, due to a suspend/resume, or a backend * driver restart. We tear down our netif structure and recreate it, but * leave the device-layer structures intact so that this is transparent to the @@ -2305,7 +2305,7 @@ static int xennet_connect(struct net_device *dev) return 0; } -/** +/* * Callback received when the backend's state changes. */ static void netback_changed(struct xenbus_device *dev,
Fixes the following W=1 kernel build warning(s): drivers/net/xen-netfront.c: In function ‘store_rxbuf’: drivers/net/xen-netfront.c:2416:16: warning: variable ‘target’ set but not used [-Wunused-but-set-variable] drivers/net/xen-netfront.c:1592: warning: Function parameter or member 'dev' not described in 'netfront_probe' drivers/net/xen-netfront.c:1592: warning: Function parameter or member 'id' not described in 'netfront_probe' drivers/net/xen-netfront.c:1669: warning: Function parameter or member 'dev' not described in 'netfront_resume' drivers/net/xen-netfront.c:2313: warning: Function parameter or member 'dev' not described in 'netback_changed' drivers/net/xen-netfront.c:2313: warning: Function parameter or member 'backend_state' not described in 'netback_changed' Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> Cc: Juergen Gross <jgross@suse.com> Cc: Stefano Stabellini <sstabellini@kernel.org> Cc: "David S. Miller" <davem@davemloft.net> Cc: Jakub Kicinski <kuba@kernel.org> Cc: Alexei Starovoitov <ast@kernel.org> Cc: Daniel Borkmann <daniel@iogearbox.net> Cc: Jesper Dangaard Brouer <hawk@kernel.org> Cc: John Fastabend <john.fastabend@gmail.com> Cc: Martin KaFai Lau <kafai@fb.com> Cc: Song Liu <songliubraving@fb.com> Cc: Yonghong Song <yhs@fb.com> Cc: Andrii Nakryiko <andrii@kernel.org> Cc: KP Singh <kpsingh@chromium.org> Cc: xen-devel@lists.xenproject.org Cc: netdev@vger.kernel.org Cc: bpf@vger.kernel.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/net/xen-netfront.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)