diff mbox series

[16/24] Switch NetBSD to QEMU_XEN (!traditional)

Message ID 20201214163623.2127-17-bouyer@netbsd.org (mailing list archive)
State New, archived
Headers show
Series NetBSD fixes | expand

Commit Message

Manuel Bouyer Dec. 14, 2020, 4:36 p.m. UTC 
---
 tools/libs/light/libxl_netbsd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Roger Pau Monné Dec. 29, 2020, 2:19 p.m. UTC | #1 
On Mon, Dec 14, 2020 at 05:36:15PM +0100, Manuel Bouyer wrote:
> ---
>  tools/libs/light/libxl_netbsd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/libs/light/libxl_netbsd.c b/tools/libs/light/libxl_netbsd.c
> index e66a393d7f..31334f932c 100644
> --- a/tools/libs/light/libxl_netbsd.c
> +++ b/tools/libs/light/libxl_netbsd.c
> @@ -110,7 +110,7 @@ out:
>  
>  libxl_device_model_version libxl__default_device_model(libxl__gc *gc)
>  {
> -    return LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN_TRADITIONAL;
> +    return LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN;
>  }

All libxl supported OSes will now be using upstream QEMU as default,
maybe it's best to just move libxl__default_device_model into
libxl_dm.c instead of having 3 equal copies in OS specific files.

Thanks, Roger.
Manuel Bouyer Jan. 4, 2021, 10:47 a.m. UTC | #2 
On Tue, Dec 29, 2020 at 03:19:14PM +0100, Roger Pau Monné wrote:
> On Mon, Dec 14, 2020 at 05:36:15PM +0100, Manuel Bouyer wrote:
> > ---
> >  tools/libs/light/libxl_netbsd.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/libs/light/libxl_netbsd.c b/tools/libs/light/libxl_netbsd.c
> > index e66a393d7f..31334f932c 100644
> > --- a/tools/libs/light/libxl_netbsd.c
> > +++ b/tools/libs/light/libxl_netbsd.c
> > @@ -110,7 +110,7 @@ out:
> >  
> >  libxl_device_model_version libxl__default_device_model(libxl__gc *gc)
> >  {
> > -    return LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN_TRADITIONAL;
> > +    return LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN;
> >  }
> 
> All libxl supported OSes will now be using upstream QEMU as default,
> maybe it's best to just move libxl__default_device_model into
> libxl_dm.c instead of having 3 equal copies in OS specific files.

I guess it would be better, yes. But I'll let the Xen developpers decide :)
diff mbox series

Patch

diff --git a/tools/libs/light/libxl_netbsd.c b/tools/libs/light/libxl_netbsd.c
index e66a393d7f..31334f932c 100644
--- a/tools/libs/light/libxl_netbsd.c
+++ b/tools/libs/light/libxl_netbsd.c
@@ -110,7 +110,7 @@  out:
 
 libxl_device_model_version libxl__default_device_model(libxl__gc *gc)
 {
-    return LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN_TRADITIONAL;
+    return LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN;
 }
 
 int libxl__pci_numdevs(libxl__gc *gc)