| Message ID | 20210129194415.3925153-2-f4bug@amsat.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/xen: Fixes to only build the XEN_PV machine | expand |
On 29/01/21 20:44, Philippe Mathieu-Daudé wrote: > hw/ide/ioport.c has a strong dependency on hw/isa/isa-bus.c: > > /usr/bin/ld: libcommon.fa.p/hw_ide_ioport.c.o: in function `ide_init_ioport': > /usr/bin/ld: hw/ide/ioport.c:61: undefined reference to `isa_register_portio_list' > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > hw/ide/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/ide/Kconfig b/hw/ide/Kconfig > index 5d9106b1ac2..41cdd9cbe03 100644 > --- a/hw/ide/Kconfig > +++ b/hw/ide/Kconfig > @@ -12,7 +12,7 @@ config IDE_PCI > > config IDE_ISA > bool > - depends on ISA_BUS > + select ISA_BUS > select IDE_QDEV > > config IDE_PIIX This is incorrect. Buses are "depended on", not selected, and this is documented in docs/devel/kconfig.rst. Paolo
diff --git a/hw/ide/Kconfig b/hw/ide/Kconfig index 5d9106b1ac2..41cdd9cbe03 100644 --- a/hw/ide/Kconfig +++ b/hw/ide/Kconfig @@ -12,7 +12,7 @@ config IDE_PCI config IDE_ISA bool - depends on ISA_BUS + select ISA_BUS select IDE_QDEV config IDE_PIIX
hw/ide/ioport.c has a strong dependency on hw/isa/isa-bus.c: /usr/bin/ld: libcommon.fa.p/hw_ide_ioport.c.o: in function `ide_init_ioport': /usr/bin/ld: hw/ide/ioport.c:61: undefined reference to `isa_register_portio_list' Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- hw/ide/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)