diff mbox series

[for-4.15] tools/tests: fix resource test build on FreeBSD

Message ID 20210205121938.4636-1-roger.pau@citrix.com (mailing list archive)
State New
Headers show
Series [for-4.15] tools/tests: fix resource test build on FreeBSD | expand

Commit Message

Roger Pau Monné Feb. 5, 2021, 12:19 p.m. UTC
error.h is not a standard header, and none of the functions declared
there are actually used by the code. This fixes the build on FreeBSD
that doesn't have error.h

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Build tested on both Linux and FreeBSD. The risk would be breaking the
build, but it's already broken on FreeBSD so there's not much to lose.
Build breakages on Linux will be spotted fast by either osstest of the
gitlab build.
---
 tools/tests/resource/test-resource.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Andrew Cooper Feb. 5, 2021, 12:50 p.m. UTC | #1
On 05/02/2021 12:19, Roger Pau Monne wrote:
> error.h is not a standard header, and none of the functions declared
> there are actually used by the code. This fixes the build on FreeBSD
> that doesn't have error.h
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Urgh sorry.  Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
Ian Jackson Feb. 5, 2021, 3:38 p.m. UTC | #2
Roger Pau Monne writes ("[PATCH for-4.15] tools/tests: fix resource test build on FreeBSD"):
> error.h is not a standard header, and none of the functions declared
> there are actually used by the code. This fixes the build on FreeBSD
> that doesn't have error.h
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> ---
> Build tested on both Linux and FreeBSD. The risk would be breaking the
> build, but it's already broken on FreeBSD so there's not much to lose.
> Build breakages on Linux will be spotted fast by either osstest of the
> gitlab build.

Release-Acked-by: Ian Jackson <iwj@xenproject.org>
Acked-by: Ian Jackson <iwj@xenproject.org>

Thanks.  I think this was probably a typo.

Ian.
diff mbox series

Patch

diff --git a/tools/tests/resource/test-resource.c b/tools/tests/resource/test-resource.c
index a409a82f44..1caaa60e62 100644
--- a/tools/tests/resource/test-resource.c
+++ b/tools/tests/resource/test-resource.c
@@ -1,6 +1,5 @@ 
 #include <err.h>
 #include <errno.h>
-#include <error.h>
 #include <stdio.h>
 #include <string.h>
 #include <sys/mman.h>