| Message ID | 20210212153953.4582-2-andrew.cooper3@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | tools: Support to use abi-dumper on libraries | expand |
Andrew Cooper writes ("[PATCH 01/10] tools/xl: Fix exit code for `xl vkbattach`"):
> Various version of gcc, when compiling with -Og, complain:
>
> xl_vkb.c: In function 'main_vkbattach':
> xl_vkb.c:79:12: error: 'rc' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> 79 | return rc;
> | ^~
>
> The dryrun_only path really does leave rc uninitalised. Introduce a done
> label for success paths to use.
>
> Fixes: a15166af7c3 ("xl: add vkb config parser and CLI")
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Release-Acked-by: Ian Jackson <iwj@xenproject.org>
Andrew Cooper writes ("[PATCH 01/10] tools/xl: Fix exit code for `xl vkbattach`"):
> Various version of gcc, when compiling with -Og, complain:
>
> xl_vkb.c: In function 'main_vkbattach':
> xl_vkb.c:79:12: error: 'rc' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> 79 | return rc;
> | ^~
>
> The dryrun_only path really does leave rc uninitalised. Introduce a done
> label for success paths to use.
>
> Fixes: a15166af7c3 ("xl: add vkb config parser and CLI")
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Ian Jackson <iwj@xenproject.org>
diff --git a/tools/xl/xl_vkb.c b/tools/xl/xl_vkb.c index f6ed9e05ee..728ac9470b 100644 --- a/tools/xl/xl_vkb.c +++ b/tools/xl/xl_vkb.c @@ -64,7 +64,7 @@ int main_vkbattach(int argc, char **argv) char *json = libxl_device_vkb_to_json(ctx, &vkb); printf("vkb: %s\n", json); free(json); - goto out; + goto done; } if (libxl_device_vkb_add(ctx, domid, &vkb, 0)) { @@ -72,6 +72,7 @@ int main_vkbattach(int argc, char **argv) rc = ERROR_FAIL; goto out; } +done: rc = 0; out:
Various version of gcc, when compiling with -Og, complain: xl_vkb.c: In function 'main_vkbattach': xl_vkb.c:79:12: error: 'rc' may be used uninitialized in this function [-Werror=maybe-uninitialized] 79 | return rc; | ^~ The dryrun_only path really does leave rc uninitalised. Introduce a done label for success paths to use. Fixes: a15166af7c3 ("xl: add vkb config parser and CLI") Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> --- CC: Ian Jackson <iwj@xenproject.org> CC: Wei Liu <wl@xen.org> CC: Anthony PERARD <anthony.perard@citrix.com> --- tools/xl/xl_vkb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)