| Message ID | 20210329161457.345360-3-george.dunlap@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,for-4.15,1/7] Intel Processor Trace Support: Add CHANGELOG.md and SUPPORT.md entries | expand |
George Dunlap writes ("[PATCH v2 for-4.15 3/7] CHANGELOG.md: Add dom0/domU zstd compression support"):
> Signed-off-by: George Dunlap <george.dunlap@citrix.com>
Release-Acked-by: Ian Jackson <iwj@xenproject.org>
Ian Jackson writes ("Re: [PATCH v2 for-4.15 3/7] CHANGELOG.md: Add dom0/domU zstd compression support"):
> George Dunlap writes ("[PATCH v2 for-4.15 3/7] CHANGELOG.md: Add dom0/domU zstd compression support"):
> > Signed-off-by: George Dunlap <george.dunlap@citrix.com>
>
> Release-Acked-by: Ian Jackson <iwj@xenproject.org>
Actually, better idea: I hereby give a blanket release ack for
anything in CHANGELOG.md that is committed by the end of Wednesday.
Whatever isn't ready by then I will look properly at. I expect us to
commit final docs updates early on Tuesday the 6th. So in practice I
think that means that any input from people who are away for Easter
needs to be finalised before the Easter weekend so that George and I
can get it properly into the tree.
Thanks,
Ian.
Hi George, On Mon, 29 Mar 2021 at 17:15, George Dunlap <george.dunlap@citrix.com> wrote: > diff --git a/CHANGELOG.md b/CHANGELOG.md > index 8c89212f14..538eae611c 100644 > --- a/CHANGELOG.md > +++ b/CHANGELOG.md > @@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) > - ARM SMMUv3 (Tech Preview) > - Intel Processor Trace support (Tech Preview) > - Named PCI devices for xl/libxl > + - Support for zstd-compressed dom0 and domU kernels Looking at the log, the feature looks x86 only (at least the dom0 part). Cheers,
> On Mar 29, 2021, at 7:54 PM, Julien Grall <julien.grall.oss@gmail.com> wrote: > > Hi George, > > On Mon, 29 Mar 2021 at 17:15, George Dunlap <george.dunlap@citrix.com> wrote: >> diff --git a/CHANGELOG.md b/CHANGELOG.md >> index 8c89212f14..538eae611c 100644 >> --- a/CHANGELOG.md >> +++ b/CHANGELOG.md >> @@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) >> - ARM SMMUv3 (Tech Preview) >> - Intel Processor Trace support (Tech Preview) >> - Named PCI devices for xl/libxl >> + - Support for zstd-compressed dom0 and domU kernels > > Looking at the log, the feature looks x86 only (at least the dom0 part). Oh, interesting. So what about the following? - Support for zstd-compressed dom0 (x86) and domU kernels -George
On 30/03/2021 11:08, George Dunlap wrote: > > >> On Mar 29, 2021, at 7:54 PM, Julien Grall <julien.grall.oss@gmail.com> wrote: >> >> Hi George, >> >> On Mon, 29 Mar 2021 at 17:15, George Dunlap <george.dunlap@citrix.com> wrote: >>> diff --git a/CHANGELOG.md b/CHANGELOG.md >>> index 8c89212f14..538eae611c 100644 >>> --- a/CHANGELOG.md >>> +++ b/CHANGELOG.md >>> @@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) >>> - ARM SMMUv3 (Tech Preview) >>> - Intel Processor Trace support (Tech Preview) >>> - Named PCI devices for xl/libxl >>> + - Support for zstd-compressed dom0 and domU kernels >> >> Looking at the log, the feature looks x86 only (at least the dom0 part). > > Oh, interesting. So what about the following? > > - Support for zstd-compressed dom0 (x86) and domU kernels Sounds fine to me. Note that I haven't tried zstd-compressed for domu Kernel on Arm. Maybe the author (Jan) can confirm whether this was plumbed in common libxc code? Cheers,
On 30.03.2021 12:14, Julien Grall wrote: > > > On 30/03/2021 11:08, George Dunlap wrote: >> >> >>> On Mar 29, 2021, at 7:54 PM, Julien Grall <julien.grall.oss@gmail.com> wrote: >>> >>> Hi George, >>> >>> On Mon, 29 Mar 2021 at 17:15, George Dunlap <george.dunlap@citrix.com> wrote: >>>> diff --git a/CHANGELOG.md b/CHANGELOG.md >>>> index 8c89212f14..538eae611c 100644 >>>> --- a/CHANGELOG.md >>>> +++ b/CHANGELOG.md >>>> @@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) >>>> - ARM SMMUv3 (Tech Preview) >>>> - Intel Processor Trace support (Tech Preview) >>>> - Named PCI devices for xl/libxl >>>> + - Support for zstd-compressed dom0 and domU kernels >>> >>> Looking at the log, the feature looks x86 only (at least the dom0 part). >> >> Oh, interesting. So what about the following? >> >> - Support for zstd-compressed dom0 (x86) and domU kernels > > Sounds fine to me. Note that I haven't tried zstd-compressed for domu > Kernel on Arm. > > Maybe the author (Jan) can confirm whether this was plumbed in common > libxc code? Well, I've followed the model used for other compression methods. I have no idea what this means or does not mean for Arm; in fact so far I was under the impression that like in the hypervisor decompression support was an x86-only feature, but from what you say I conclude I have been wrong with this. Jan
On 30.03.2021 12:08, George Dunlap wrote: >> On Mar 29, 2021, at 7:54 PM, Julien Grall <julien.grall.oss@gmail.com> wrote: >> On Mon, 29 Mar 2021 at 17:15, George Dunlap <george.dunlap@citrix.com> wrote: >>> diff --git a/CHANGELOG.md b/CHANGELOG.md >>> index 8c89212f14..538eae611c 100644 >>> --- a/CHANGELOG.md >>> +++ b/CHANGELOG.md >>> @@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) >>> - ARM SMMUv3 (Tech Preview) >>> - Intel Processor Trace support (Tech Preview) >>> - Named PCI devices for xl/libxl >>> + - Support for zstd-compressed dom0 and domU kernels >> >> Looking at the log, the feature looks x86 only (at least the dom0 part). > > Oh, interesting. So what about the following? > > - Support for zstd-compressed dom0 (x86) and domU kernels Then: Acked-by: Jan Beulich <jbeulich@suse.com> Jan
On 30/03/2021 11:56, Jan Beulich wrote: > On 30.03.2021 12:14, Julien Grall wrote: >> >> >> On 30/03/2021 11:08, George Dunlap wrote: >>> >>> >>>> On Mar 29, 2021, at 7:54 PM, Julien Grall <julien.grall.oss@gmail.com> wrote: >>>> >>>> Hi George, >>>> >>>> On Mon, 29 Mar 2021 at 17:15, George Dunlap <george.dunlap@citrix.com> wrote: >>>>> diff --git a/CHANGELOG.md b/CHANGELOG.md >>>>> index 8c89212f14..538eae611c 100644 >>>>> --- a/CHANGELOG.md >>>>> +++ b/CHANGELOG.md >>>>> @@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) >>>>> - ARM SMMUv3 (Tech Preview) >>>>> - Intel Processor Trace support (Tech Preview) >>>>> - Named PCI devices for xl/libxl >>>>> + - Support for zstd-compressed dom0 and domU kernels >>>> >>>> Looking at the log, the feature looks x86 only (at least the dom0 part). >>> >>> Oh, interesting. So what about the following? >>> >>> - Support for zstd-compressed dom0 (x86) and domU kernels >> >> Sounds fine to me. Note that I haven't tried zstd-compressed for domu >> Kernel on Arm. >> >> Maybe the author (Jan) can confirm whether this was plumbed in common >> libxc code? > > Well, I've followed the model used for other compression methods. I have > no idea what this means or does not mean for Arm; in fact so far I was > under the impression that like in the hypervisor decompression support > was an x86-only feature, but from what you say I conclude I have been > wrong with this. We support gzip for dom0. For guests, I am not entirely sure what the state as I tend to uncompressed kernel every time. Cheers,
diff --git a/CHANGELOG.md b/CHANGELOG.md index 8c89212f14..538eae611c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - ARM SMMUv3 (Tech Preview) - Intel Processor Trace support (Tech Preview) - Named PCI devices for xl/libxl + - Support for zstd-compressed dom0 and domU kernels ## Removed / support downgraded
Signed-off-by: George Dunlap <george.dunlap@citrix.com> --- v2: - domU support also added CC: Jan Beulich <jbeulich@suse.com> CC: Ian Jackson <ian.jackson@citrix.com> CC: Andrew Cooper <andrew.cooper3@citrix.com> --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+)