@@ -615,9 +615,14 @@ int __init dom0_construct_pv(struct domain *d,
{
v->arch.pv.failsafe_callback_cs = FLAT_COMPAT_KERNEL_CS;
v->arch.pv.event_callback_cs = FLAT_COMPAT_KERNEL_CS;
- }
- if ( !compat )
+ /* Monitor table already created by switch_compat(). */
+ l4start = l4tab = __va(pagetable_get_paddr(v->arch.guest_table));
+ /* See public/xen.h on why the following is needed. */
+ maddr_to_page(mpt_alloc)->u.inuse.type_info = PGT_l3_page_table;
+ l3start = __va(mpt_alloc); mpt_alloc += PAGE_SIZE;
+ }
+ else
{
maddr_to_page(mpt_alloc)->u.inuse.type_info = PGT_l4_page_table;
l4start = l4tab = __va(mpt_alloc); mpt_alloc += PAGE_SIZE;
@@ -626,14 +631,6 @@ int __init dom0_construct_pv(struct domain *d,
d, INVALID_MFN, true);
v->arch.guest_table = pagetable_from_paddr(__pa(l4start));
}
- else
- {
- /* Monitor table already created by switch_compat(). */
- l4start = l4tab = __va(pagetable_get_paddr(v->arch.guest_table));
- /* See public/xen.h on why the following is needed. */
- maddr_to_page(mpt_alloc)->u.inuse.type_info = PGT_l3_page_table;
- l3start = __va(mpt_alloc); mpt_alloc += PAGE_SIZE;
- }
l4tab += l4_table_offset(v_start);
pfn = alloc_spfn;
This removes a visually-werid layout of conditionals. Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> --- CC: Jan Beulich <JBeulich@suse.com> CC: Roger Pau Monné <roger.pau@citrix.com> CC: Wei Liu <wl@xen.org> --- xen/arch/x86/pv/dom0_build.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-)