diff mbox series

[v2] tools: fix incorrect suggestions for XENCONSOLED_TRACE on BSD

Message ID 20210506151701.1343-1-olaf@aepfle.de (mailing list archive)
State New
Headers show
Series [v2] tools: fix incorrect suggestions for XENCONSOLED_TRACE on BSD | expand

Commit Message

Olaf Hering May 6, 2021, 3:17 p.m. UTC
--log does not take a file, it specifies what is supposed to be logged.

Also separate the XENSTORED and XENCONSOLED variables by a newline.

Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
 tools/hotplug/FreeBSD/rc.d/xencommons.in | 5 +++--
 tools/hotplug/NetBSD/rc.d/xencommons.in  | 5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)

Comments

Andrew Cooper May 6, 2021, 5:42 p.m. UTC | #1
On 06/05/2021 16:17, Olaf Hering wrote:
> --log does not take a file, it specifies what is supposed to be logged.
>
> Also separate the XENSTORED and XENCONSOLED variables by a newline.
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
diff mbox series

Patch

diff --git a/tools/hotplug/FreeBSD/rc.d/xencommons.in b/tools/hotplug/FreeBSD/rc.d/xencommons.in
index ccd5a9b055..4c61d8c94e 100644
--- a/tools/hotplug/FreeBSD/rc.d/xencommons.in
+++ b/tools/hotplug/FreeBSD/rc.d/xencommons.in
@@ -21,9 +21,10 @@  status_cmd="xen_status"
 extra_commands="status"
 required_files="/dev/xen/xenstored"
 
-XENSTORED_PIDFILE="@XEN_RUN_DIR@/xenstored.pid"
 XENCONSOLED_PIDFILE="@XEN_RUN_DIR@/xenconsoled.pid"
-#XENCONSOLED_TRACE="@XEN_LOG_DIR@/xenconsole-trace.log"
+#XENCONSOLED_TRACE="none|guest|hv|all"
+
+XENSTORED_PIDFILE="@XEN_RUN_DIR@/xenstored.pid"
 #XENSTORED_TRACE="@XEN_LOG_DIR@/xen/xenstore-trace.log"
 
 load_rc_config $name
diff --git a/tools/hotplug/NetBSD/rc.d/xencommons.in b/tools/hotplug/NetBSD/rc.d/xencommons.in
index 3981787eac..80e518f5de 100644
--- a/tools/hotplug/NetBSD/rc.d/xencommons.in
+++ b/tools/hotplug/NetBSD/rc.d/xencommons.in
@@ -20,9 +20,10 @@  status_cmd="xen_status"
 extra_commands="status"
 required_files="/kern/xen/privcmd"
 
-XENSTORED_PIDFILE="@XEN_RUN_DIR@/xenstored.pid"
 XENCONSOLED_PIDFILE="@XEN_RUN_DIR@/xenconsoled.pid"
-#XENCONSOLED_TRACE="@XEN_LOG_DIR@/xenconsole-trace.log"
+#XENCONSOLED_TRACE="none|guest|hv|all"
+
+XENSTORED_PIDFILE="@XEN_RUN_DIR@/xenstored.pid"
 #XENSTORED_TRACE="@XEN_LOG_DIR@/xenstore-trace.log"
 
 xen_precmd()