From patchwork Thu Jun 24 14:46:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 12342329 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B81A6C49EA5 for ; Thu, 24 Jun 2021 14:47:13 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 57021613C3 for ; Thu, 24 Jun 2021 14:47:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 57021613C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.146858.270374 (Exim 4.92) (envelope-from ) id 1lwQdC-0006KW-0j; Thu, 24 Jun 2021 14:47:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 146858.270374; Thu, 24 Jun 2021 14:47:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lwQdB-0006KP-Sb; Thu, 24 Jun 2021 14:47:01 +0000 Received: by outflank-mailman (input) for mailman id 146858; Thu, 24 Jun 2021 14:47:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lwQdA-0006KJ-FR for xen-devel@lists.xenproject.org; Thu, 24 Jun 2021 14:47:00 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lwQd9-0002Dh-37; Thu, 24 Jun 2021 14:46:59 +0000 Received: from 54-240-197-227.amazon.com ([54.240.197.227] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lwQd8-000486-Qr; Thu, 24 Jun 2021 14:46:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=XCk4lQYg4y7RtUs31wkreOLsu7v4xKjO1fVnBgQiBnI=; b=Iz6av1pTXigGNWzHmUoHkt75Ma Lik//fCZyrpXmjwZKn2Of2WY34tTTZxOaeqF2C9HjsuOmCqeV3FzN76ySatBmMojx8FBmMlAaR7DS i+RwO+3omLZ8i01DXN1tT3Bc1+Otzu6rjGm7X0UXUmPcQlIMY1vr8J67k70WSULxKvRo=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: raphning@amazon.co.uk, doebel@amazon.de, Julien Grall , Ian Jackson , Wei Liu , Juergen Gross , Julien Grall Subject: [PATCH] tools/xenstored: Remove redundant check in socket_can_process() Date: Thu, 24 Jun 2021 15:46:55 +0100 Message-Id: <20210624144655.12900-1-julien@xen.org> X-Mailer: git-send-email 2.17.1 From: Julien Grall Commit 3adfb50315d9 ("tools/xenstored: Introduce a wrapper for conn->funcs->can_{read, write}") consolidated the check !conn->is_ignored in two new wrappers. This means the check in socket_can_process() is now redundant. In fact it should have been removed in orignal commit (as it was done for the domain helpers). Reported-by: Raphael Ning Reviewed-by: Juergen Gross --- tools/xenstore/xenstored_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index 9ffd2ac66d3e..cf7297a96cb1 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -1752,7 +1752,7 @@ static bool socket_can_process(struct connection *conn, int mask) return false; } - return (fds[conn->pollfd_idx].revents & mask) && !conn->is_ignored; + return (fds[conn->pollfd_idx].revents & mask); } static bool socket_can_write(struct connection *conn)