From patchwork Wed Jul 7 07:15:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Roger_Pau_Monn=C3=A9?= X-Patchwork-Id: 12361927 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B451CC07E95 for ; Wed, 7 Jul 2021 07:16:09 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5CFE761C7F for ; Wed, 7 Jul 2021 07:16:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5CFE761C7F Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.151975.280809 (Exim 4.92) (envelope-from ) id 1m11mh-0007XP-9d; Wed, 07 Jul 2021 07:15:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 151975.280809; Wed, 07 Jul 2021 07:15:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m11mh-0007XI-5J; Wed, 07 Jul 2021 07:15:51 +0000 Received: by outflank-mailman (input) for mailman id 151975; Wed, 07 Jul 2021 07:15:49 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m11mf-0007XC-7p for xen-devel@lists.xenproject.org; Wed, 07 Jul 2021 07:15:49 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 26dd39c6-def3-11eb-84dc-12813bfff9fa; Wed, 07 Jul 2021 07:15:48 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 26dd39c6-def3-11eb-84dc-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1625642148; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=Hn/VTdoW8FjMLt1k0X+caeWzYZXTiG2WgypLgMAK72w=; b=EBEI+d2FOqEfhiyUrYMeZgzMGr0e4Ca4WfNA5BELG1qe1awVkDrS1mFG wce/o4bNCl1awS/sWavETTl0tcV0UZn7h8K6CjKze4kzzqCtksK7C1EOZ z+oVE4YHcUhSbcDl8lAHxgvr9if1MNIIpxtg8H8V620y9LpFkRx/DM/xJ g=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: cvPudFtrfMEzYPEQToFdFSIQVoZMB0n4yyvarWtLGSmnL/N2c367yhiMJIfGHeAJYa36GXClYG CT7SfgbvFloKFXWsbKjK08T46fIsrGwJWQ1GyybKeP40ssRTS9/2iNgp3eiYte7zYoaUfI85ds /WkT6ikjKraHluUuwRmilZavIe1nZmypyZK4dDoQXI2UPzfWGtHWy/pEz87hgDvJSDylGcdk9d KF603FhY/arr4tsJTTUHbyjWpdu4WpJ2mk0dAlfeFvF9Kvda2t3U+Z9Q0ytr/SEokrZlb5uPnj gIA= X-SBRS: 5.1 X-MesageID: 47701601 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:3rPjPqN+3FA2T8BcTvajsMiBIKoaSvp037BN7SxMoH1uHfBw8v rEoB1173HJYVoqOU3I++rwXZVoMEm9yXcd2+B4V9qftW/dyQiVxa5ZnO3fKlbbaknDH4BmpM VdWpk7JNrsDUVryebWiTPIa+rIGeP3iZxBD43lvhBQcT0= X-IronPort-AV: E=Sophos;i="5.83,331,1616472000"; d="scan'208";a="47701601" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=brFRIP6Mshp81an9xbdl90u/u5gWDJLvQUFJ88F0UNZMvGtXqsKOsdtBZcmJeBIkLbzYWDNcpyA9mxt95oIyGIGnoypkCgEpOoybkDpk+jb6wgSYXSbR5T7ElDVueNJn3Tlq170NTY9Vh1wjNm6pxhAAmKcZoo1qNYGFvmJ5QmKd6Gp2rIY9THhnoNWwDmFmsEEutBJlVPlyaLEPxoyx9IPkQqXliCrhr8Xwlsg0WDdVEdTXDd3R5M9VWex5ao4DdrgcwLvkq6byghBY5/hcJvzUUW704ir8+HXW7QWl6S07GnZyaCxkFd/IjuCB59+gx+qGOjRBqHi7J7yxdyH3uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cs8ymGBrF7j+G3jCG9nSDz3vu1J1AeR1C6gb1yeBOWs=; b=hS0Zfklq47yNX4uWsgsDUAhUXdYZXk/n2/kO1fiHTh5jXOvfyqNGS/OiAjWFWdNP3lkTYWWUL/G1TlPmG5CHpVbkoW1gUN4yQISkpKKhmFJPwl9zsURfd2Aha+0MAObXkhuWw1Wux20LO2wjrZ31zW4StnUXASNJKL7XTziRWvVR/CKAm7RK7+ERj2OjzTMDrEyxLy9FZkSPzOnmkZ4QzpHp7NkaApLGudj6Zq9x0dc1ff7cUVOjwF5ifo5FmClfSlSnOWf2k6HYCyindihbJR/mEWxc39lN+Q1jmpp8H5O1s3SI3Svl2fFd0anubPqQZRnnhJS37Pd4qPm0jckBBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cs8ymGBrF7j+G3jCG9nSDz3vu1J1AeR1C6gb1yeBOWs=; b=J156MwWRqZdUUTT2abG/VzPOzlZRWqtPd2YBu5e9iF9Zd41b66/uwzLv/dwrBoxyw8h7lLRVV6cFrswN/bInH2KydQIh7pMYtkBiKRPVUa+M4aB31MKkl+5YsnDuLVi+uDmOo4WW6T33T57bUB/+chY/BYR3G3SXhhAGIy1iGug= From: Roger Pau Monne To: CC: Roger Pau Monne , George Dunlap , Nick Rosbrook , Ian Jackson , Wei Liu , Ting-Wei Lan Subject: [PATCH] tools/go: honor append build flags Date: Wed, 7 Jul 2021 09:15:31 +0200 Message-ID: <20210707071531.69001-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.31.1 X-ClientProxiedBy: MR2P264CA0051.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:31::15) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 41868968-1388-455e-7486-08d94117097b X-MS-TrafficTypeDiagnostic: DM6PR03MB3577: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Fxs7ggKq+1kOLeWkAH+5X56VahEC3RW1Z/mJnFOkb5xIARIJ0kQ6yl9TsuVXp5/6tYBhCDFWcFPpaDySFZ6YjirQoMn+4T0a9f/cTJ+eytqnEqh8iVjO43JUhjhODNkv+CeuV7WZE1QI4i6CfZC/rB00/x0Z5u9gJ/y9tujAw8kLozGYvApLCFZ9snxYKAHam/qoad4LdkLGxuPbJ5ovg3N3btvjBdQzIFfmX9zeOKORZaLFv9l3mr/1HtMwU0Pt7JqwTnMjTsJLGhaGdqnuILIjo9L2jHfb25ZrER8g0rqQ/0T/jCE/MvFOLQ8Wopw6pKEhiXDznxSmxNLEpv7ZRGvB8Kxm+/PkqAGn9cFVf0mBbFdmhCQyCu1mwBHGfMy8/mx9yH1mxFQIXYIsCIEbanXIxZKg78AmIhManbsGXZL8DtZfYt2MiCAWLB2IfSRlCaWD4puVP6Q9rHszBf1UliI8H2Ll/fOrXtYLiVCE99uCaK0SupT45bPViI3Qry31b1X3NFEFg98Ii2etbF4fwjqTFEhK5tu/euxOpub8JXD5nSCivrwqF9wRC3WpazA9fMmb3ljHuHU0sZSOdkjuehQe85spr2ynOGRxsASo7hqd30Rhd5fvDjsey5ea2zNcn5OZJTJye/t6USf5RVXauA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(136003)(346002)(396003)(366004)(376002)(26005)(186003)(66476007)(2906002)(478600001)(36756003)(8936002)(6486002)(38100700002)(6916009)(6666004)(86362001)(8676002)(54906003)(956004)(316002)(1076003)(2616005)(5660300002)(4326008)(83380400001)(66556008)(66946007)(6496006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?bsq6re5ViLqiHyO+VrVv01e8cgga?= =?utf-8?q?nKdmL7338vYo4hERrt/UTZ6NBnhSCRy3RSWUnePdc0CgYbxYk232Z2InHCrxc5J6Q?= =?utf-8?q?jrMefc+Dhc+bsrgMWHLNd0hNLVGUEtz70FO++c5BxU/lMIkxqBTm1/dAhLZxnEFtC?= =?utf-8?q?7vvb16pcQ+L+DQ//+lHKTeQkoxLzXpoxKaN4wq0pNPG80UgCR4bsfO9ZN92EUABO3?= =?utf-8?q?v9gHukJ/zX/Y5PVXPev6m2+h2Mi1sOG+noCo6VM6J7Vl6LMD/nAMgwlLeh64TI0dC?= =?utf-8?q?ZDJstg7XZ4B0SzKsF7YobvihcBQNFAmhhfzumeJAfi+pLMfU9VniXacwPJQ+R9Y8V?= =?utf-8?q?nnOLWeFwQn0OPUDQPFcVUIOwfVh5ajGWpDlRY3xqz+aMgGmkZprq+lErGnWDaxYqZ?= =?utf-8?q?V410ubS/ukRtj/3/mQpKYMdTu/EPK5zy65MlCAotxJjDq9H71wPjwLI1Vlw3eY2A7?= =?utf-8?q?mXs/RGELWAVBERRKNQ9TEVmuaVkYKMeu28hd56L28CodO/B0t/Ony/Yo6/XKr514c?= =?utf-8?q?ig9SkQcH9KxdoZpWwmnc3ecg6IAqVnHYZXjjnwOQECiivzBGsl3y+KIrE8ZDQUBqz?= =?utf-8?q?Zlyu+ZYyonWvujTY2Tj3+jbRU+oYvNCmnjZ4bd0nWm7+JaWyjWdT2g2PlA+3BX5ed?= =?utf-8?q?14uH+dXgKxL5uflxJq1rWbtDwIGsLni7IG1VFdA/Bius0s2wsl+cLsbS4A94aXgsd?= =?utf-8?q?uJOV+YqIz6sd5L7mYQnpMUxf6ZcGx2GX6nhGLXE05+5MOh6JD/w9fGUuvORO11Hy2?= =?utf-8?q?8GvTZLlIcRc2G6ZKbCWJ47LZ8eFL1fL03sjo3WB7nOCwFIj9i+HzniFdPELV2IynK?= =?utf-8?q?8j6PYEHqxs4mrMooLhb4ZRyJ6E32+V3M1xawS05ZLCZNGmxxaPQvxsSgvgAFzMBzK?= =?utf-8?q?uBSj3lWHd54nWB3tC385Y3w0ZHaP8FVoyMXwE6WmsnHxBCeCWWIwP3UWhLCUqodyu?= =?utf-8?q?TlA8AWiLIqphEbdpYZnUzAHFOENDG76qiBnRF8llXhxZsQ82NQ3gxGs/CUiAx1bR6?= =?utf-8?q?Wzx5G9lN990IpOqL1yIZgZ+fMbvHSFABl1c0yKFAkzuBkZs7MxGAup31xzlGqyvRY?= =?utf-8?q?pbpWV2PbTQ6eaJKQddsMMODy+nyQIIgg4tzI/Lj0y1HDdXcLXaWuTG+8qqh08YbD4?= =?utf-8?q?str8hgLRmVwfWX6BpckEh+toPDK56rm/6AVZ83mrfcSL5dQ5EjH5Zw+8wpXG4hNyK?= =?utf-8?q?/KTw+de+irFMGjQUhx2S9L9mNyjRu+7EcohVQaIjcW3Y9rMJxvTseRWJ5qheG8R8K?= =?utf-8?q?l6cJm/0038KQoLhi?= X-MS-Exchange-CrossTenant-Network-Message-Id: 41868968-1388-455e-7486-08d94117097b X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2021 07:15:45.0785 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NyFpSn4sDWYTTb98x1XF+bpwWTOEQOyLA1IBZQ5S6wwN1UjsdYHE0kr8h9FuLayc41eQa8yMCnOX0eTlTe45/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3577 X-OriginatorOrg: citrix.com Make the go build use APPEND_{C/LD}FLAGS when necessary, just like other parts of the build. Reported-by: Ting-Wei Lan Signed-off-by: Roger Pau Monné Acked-by: Nick Rosbrook --- Note sure if it's the best way to add the appended flags, I'm not familiar with the go build system. In any case this fixes the build when required libraries (ie: yajl) are not part of the system search path and instead passed in APPEND_{C/LD}FLAGS. --- tools/golang/xenlight/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/golang/xenlight/Makefile b/tools/golang/xenlight/Makefile index e394ef9b2b..64671f246c 100644 --- a/tools/golang/xenlight/Makefile +++ b/tools/golang/xenlight/Makefile @@ -27,7 +27,7 @@ GOXL_GEN_FILES = types.gen.go helpers.gen.go # so that it can find the actual library. .PHONY: build build: xenlight.go $(GOXL_GEN_FILES) - CGO_CFLAGS="$(CFLAGS_libxenlight) $(CFLAGS_libxentoollog)" CGO_LDFLAGS="$(LDLIBS_libxenlight) $(LDLIBS_libxentoollog) -L$(XEN_libxenlight) -L$(XEN_libxentoollog)" $(GO) build -x + CGO_CFLAGS="$(CFLAGS_libxenlight) $(CFLAGS_libxentoollog) $(APPEND_CFLAGS)" CGO_LDFLAGS="$(LDLIBS_libxenlight) $(LDLIBS_libxentoollog) -L$(XEN_libxenlight) -L$(XEN_libxentoollog) $(APPEND_LDFLAGS)" $(GO) build -x .PHONY: install install: build