From patchwork Fri Aug 20 11:54:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksandr Andrushchenko X-Patchwork-Id: 12449141 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95EB5C4338F for ; Fri, 20 Aug 2021 11:54:35 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 573F961053 for ; Fri, 20 Aug 2021 11:54:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 573F961053 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.169467.309586 (Exim 4.92) (envelope-from ) id 1mH36R-0007Ie-Ez; Fri, 20 Aug 2021 11:54:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 169467.309586; Fri, 20 Aug 2021 11:54:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mH36R-0007IX-Br; Fri, 20 Aug 2021 11:54:27 +0000 Received: by outflank-mailman (input) for mailman id 169467; Fri, 20 Aug 2021 11:54:26 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mH36Q-0007Ha-5t for xen-devel@lists.xenproject.org; Fri, 20 Aug 2021 11:54:26 +0000 Received: from mail-lj1-x232.google.com (unknown [2a00:1450:4864:20::232]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 904fd6b3-48ed-4393-854f-5a487dceaf27; Fri, 20 Aug 2021 11:54:25 +0000 (UTC) Received: by mail-lj1-x232.google.com with SMTP id q21so16866304ljj.6 for ; Fri, 20 Aug 2021 04:54:25 -0700 (PDT) Received: from a2klaptop.localdomain ([185.199.97.5]) by smtp.gmail.com with ESMTPSA id z13sm532779ljj.43.2021.08.20.04.54.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Aug 2021 04:54:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 904fd6b3-48ed-4393-854f-5a487dceaf27 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=g6dP90LhiVMec/QpqzfPTZ0GUWlCB10odQ+8whyOwLY=; b=qV/ZJ2oTQQixmUh1PSEBUPRhMLKkQhetJ8DgGDnFuDcvwPflW61yV1KkOAMjWyfzsj iiZ6CpwGtwCb36f725h1vI1in/ttIif7W6vCOWk6weHDT2bS4F1dW0EtAwg1C4CwHLyn B6kIgowk2oIZSkcK6re7CKDUXe3EXcNAAFObUc+soiEAQg67CVV/1OAvHaA7V5u8uG2h IjveTMlPjx0BTXmEsCY0g1WGj7rVRGTHJkHXxF52DqEMg3kyXZy+vrIswoZBCT3l4g77 v8bLSNL75jaD7Wi1g26/VxQ0pXe/CSNqpImshSzQmG5kRgKWuqnZCU4MPZs8Uc1tP0HS Ejww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=g6dP90LhiVMec/QpqzfPTZ0GUWlCB10odQ+8whyOwLY=; b=oNIsMRb1qvIafXRhCnnC26aeRTGUgutK4tMy1nv9tKOOyfYy5wD6f+yHCcFD5g7Qwl RmnCSmN38/wI4goyeKwpvJ9miTyTptZ0oHxj4iZZe1joMORPCkWQOKZJTLM4TsmHe2OT 2lFu0YHtIkcjRRqa0mjPbIGoqHLta0JjrRQKa+lMHvbxIRpDqFHMa4BBGaGYKhQhVl2P c6RuP10o6H2rIFhOWWHLr83cerSIJYExw5fI6MRAcQLC6KG3i/5Ri1A2vzwFFy+Tr7R9 rB7pIOKl4Ck6VSKj+P7wGNKHOPXUnEcLdtpVH8NHX6aKrAf8OuIQmkHWY7QQrW8OyrJo PtBA== X-Gm-Message-State: AOAM5326j3YEbixAdOmCYCysQcVQS2SYtq/RJ6vV9u6G8LmY21DDFQsV NaHS6VsjCYeblZOGjsnegKU= X-Google-Smtp-Source: ABdhPJwtAtZCFblSYr+UzaxuqpNe/hdK1iEXM4gqWh2MrNqkBBpxSM1HJN5T18d/NbKFhfqNCWznig== X-Received: by 2002:a05:651c:30d:: with SMTP id a13mr14917993ljp.393.1629460464383; Fri, 20 Aug 2021 04:54:24 -0700 (PDT) From: Oleksandr Andrushchenko To: andrew.cooper3@citrix.com, george.dunlap@citrix.com, iwj@xenproject.org, jbeulich@suse.com, julien@xen.org, sstabellini@kernel.org, wl@xen.org, xen-devel@lists.xenproject.org Cc: Oleksandr Andrushchenko Subject: [PATCH] ns16550: Properly gate Exar PCIe UART cards support Date: Fri, 20 Aug 2021 14:54:22 +0300 Message-Id: <20210820115422.2185145-1-andr2000@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 From: Oleksandr Andrushchenko This fixes Arm build which doesn't have ns16550 PCI support. ns16550.c:313:5: error: implicit declaration of function 'enable_exar_enhanced_bits' [-Werror=implicit-function-declaration] 313 | enable_exar_enhanced_bits(uart); | ^~~~~~~~~~~~~~~~~~~~~~~~~ Fixes: 5ffd37db2ff6 ("ns16550: add Exar PCIe UART cards support") Signed-off-by: Oleksandr Andrushchenko Reviewed-by: Jan Beulich --- xen/drivers/char/ns16550.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c index b777c8711ee0..e2c24082c368 100644 --- a/xen/drivers/char/ns16550.c +++ b/xen/drivers/char/ns16550.c @@ -308,7 +308,7 @@ static void ns16550_setup_preirq(struct ns16550 *uart) /* Handle the DesignWare 8250 'busy-detect' quirk. */ handle_dw_usr_busy_quirk(uart); -#ifdef CONFIG_HAS_PCI +#ifdef NS16550_PCI /* Enable Exar "Enhanced function bits" */ enable_exar_enhanced_bits(uart); #endif