| Message ID | 20211022064800.14978-6-jgross@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | xen: cleanup detection of non-essential pv devices | expand |
Hi, Juergen! On 22.10.21 09:48, Juergen Gross wrote: > The Xen pv sound driver is not essential for booting. Set the respective > flag. > > Signed-off-by: Juergen Gross <jgross@suse.com> Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> > --- > sound/xen/xen_snd_front.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/xen/xen_snd_front.c b/sound/xen/xen_snd_front.c > index 2cb0a19be2b8..7be9fbcf788f 100644 > --- a/sound/xen/xen_snd_front.c > +++ b/sound/xen/xen_snd_front.c > @@ -358,6 +358,7 @@ static struct xenbus_driver xen_driver = { > .probe = xen_drv_probe, > .remove = xen_drv_remove, > .otherend_changed = sndback_changed, > + .not_essential = true; > }; > > static int __init xen_drv_init(void)
Hi Juergen,
I love your patch! Yet something to improve:
[auto build test ERROR on xen-tip/linux-next]
[also build test ERROR on tty/tty-testing tiwai-sound/for-next hid/for-next linus/master v5.15 next-20211106]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Juergen-Gross/xen-cleanup-detection-of-non-essential-pv-devices/20211022-145043
base: https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git linux-next
config: arm64-randconfig-r005-20211025 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project a461fa64bb37cffd73f683c74f6b0780379fc2ca)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/ed8f15a6cafc5414c3821aad66273c580034c3c0
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Juergen-Gross/xen-cleanup-detection-of-non-essential-pv-devices/20211022-145043
git checkout ed8f15a6cafc5414c3821aad66273c580034c3c0
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash sound/xen/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> sound/xen/xen_snd_front.c:361:23: error: unexpected ';' before '}'
.not_essential = true;
^
1 error generated.
vim +361 sound/xen/xen_snd_front.c
355
356 static struct xenbus_driver xen_driver = {
357 .ids = xen_drv_ids,
358 .probe = xen_drv_probe,
359 .remove = xen_drv_remove,
360 .otherend_changed = sndback_changed,
> 361 .not_essential = true;
362 };
363
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
diff --git a/sound/xen/xen_snd_front.c b/sound/xen/xen_snd_front.c index 2cb0a19be2b8..7be9fbcf788f 100644 --- a/sound/xen/xen_snd_front.c +++ b/sound/xen/xen_snd_front.c @@ -358,6 +358,7 @@ static struct xenbus_driver xen_driver = { .probe = xen_drv_probe, .remove = xen_drv_remove, .otherend_changed = sndback_changed, + .not_essential = true; }; static int __init xen_drv_init(void)
The Xen pv sound driver is not essential for booting. Set the respective flag. Signed-off-by: Juergen Gross <jgross@suse.com> --- sound/xen/xen_snd_front.c | 1 + 1 file changed, 1 insertion(+)