| Message ID | 20211115121741.3719-3-roger.pau@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | gnttab: fallout/improvements from max version | expand |
On 15.11.2021 13:17, Roger Pau Monne wrote: > Set the grant table version for the created domains to use version 1, > as that's the used by the test cases. Without setting the grant > version the domains for the tests cannot be created. > > Fixes: 7379f9e10a ('gnttab: allow setting max version per-domain') > Reported-by: Andrew Cooper <andrew.cooper3@citrix.com> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> Reviewed-by: Jan Beulich <jbeulich@suse.com>
On 15/11/2021 12:17, Roger Pau Monne wrote: > Set the grant table version for the created domains to use version 1, > as that's the used by the test cases. Without setting the grant > version the domains for the tests cannot be created. > > Fixes: 7379f9e10a ('gnttab: allow setting max version per-domain') > Reported-by: Andrew Cooper <andrew.cooper3@citrix.com> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
diff --git a/tools/tests/resource/test-resource.c b/tools/tests/resource/test-resource.c index 988f96f7c1..0557f8a1b5 100644 --- a/tools/tests/resource/test-resource.c +++ b/tools/tests/resource/test-resource.c @@ -120,6 +120,7 @@ static void test_domain_configurations(void) .create = { .max_vcpus = 2, .max_grant_frames = 40, + .grant_opts = XEN_DOMCTL_GRANT_version(1), }, }, { @@ -128,6 +129,7 @@ static void test_domain_configurations(void) .flags = XEN_DOMCTL_CDF_hvm, .max_vcpus = 2, .max_grant_frames = 40, + .grant_opts = XEN_DOMCTL_GRANT_version(1), .arch = { .emulation_flags = XEN_X86_EMU_LAPIC, }, @@ -140,6 +142,7 @@ static void test_domain_configurations(void) .flags = XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap, .max_vcpus = 2, .max_grant_frames = 40, + .grant_opts = XEN_DOMCTL_GRANT_version(1), }, }, #endif
Set the grant table version for the created domains to use version 1, as that's the used by the test cases. Without setting the grant version the domains for the tests cannot be created. Fixes: 7379f9e10a ('gnttab: allow setting max version per-domain') Reported-by: Andrew Cooper <andrew.cooper3@citrix.com> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> --- Cc: Ian Jackson <iwj@xenproject.org> This patch only modifies a test, so it should be safe to commit as it's not going to cause any changes to the hypervisor or the tools. Worse that could happen is it makes the test even more broken, but it's already unusable. --- tools/tests/resource/test-resource.c | 3 +++ 1 file changed, 3 insertions(+)