From patchwork Wed Nov 24 14:38:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ian Jackson X-Patchwork-Id: 12637017 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83C86C433F5 for ; Wed, 24 Nov 2021 14:39:26 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.230456.398368 (Exim 4.92) (envelope-from ) id 1mptQJ-0005q9-2Q; Wed, 24 Nov 2021 14:38:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 230456.398368; Wed, 24 Nov 2021 14:38:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mptQI-0005q2-Vc; Wed, 24 Nov 2021 14:38:58 +0000 Received: by outflank-mailman (input) for mailman id 230456; Wed, 24 Nov 2021 14:38:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mptQH-0005pw-Af for xen-devel@lists.xenproject.org; Wed, 24 Nov 2021 14:38:57 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mptQH-0000Pg-97 for xen-devel@lists.xenproject.org; Wed, 24 Nov 2021 14:38:57 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1mptQH-0003I7-60 for xen-devel@lists.xenproject.org; Wed, 24 Nov 2021 14:38:57 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1mptQ5-0002v9-1m; Wed, 24 Nov 2021 14:38:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-Id:Date:Subject:Cc:To:From; bh=yL3nNJ0wENfliK/XlGH4BPoHU6YQulLqCIVl+AZ8Vk0=; b=p6Zb6Z44rbTxz2QhMuF+FogfYr T3+f69qEJ4J0T3uXBYMUMWhKSqarF1a+RkGbgNNG771/YghwmXxlbHeh1HrIiqg0QbfDOP/VnJheJ nfWn/y6OkBYv6ExOCl00NwAFBk8I8tF8Wpo2Cr4Xup+83wbEP/JqzdyDRgfN5y4WZkTk=; From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: Ian Jackson , =?utf-8?q?Roger_Pau_Monn=C3=A9?= Subject: [OSSTEST PATCH] mg-repro-setup: Make ordinary alloc: work again Date: Wed, 24 Nov 2021 14:38:33 +0000 Message-Id: <20211124143833.23480-1-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 In e7febe5f6edc, we hosted an error earlier in the script. But in the old location, OSSTEST_TASK would always be set if statictask was. In the new one, that hasn't been done yet. No release implications since it touches a by-hand utility only. Fixes: e7febe5f6edc "mg-repro-setup: Promote an error test to before builds (nfc)" CC: Roger Pau Monné Signed-off-by: Ian Jackson Release-Acked-by: Ian Jackson --- mg-repro-setup | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mg-repro-setup b/mg-repro-setup index 895f29963..b00e182f3 100755 --- a/mg-repro-setup +++ b/mg-repro-setup @@ -254,7 +254,7 @@ while [ $# -ne 0 ]; do done if [ "${alloc_idents[*]}" ]; then - if [ x"$OSSTEST_TASK" = x ]; then + if [ x"$OSSTEST_TASK" = x ] && ! $statictask; then # We would have to make a dynamic task and hold the # fd for it in this script. Would be quite awkward. echo >&2 'cannot hand-allocate in a way that will free'