From patchwork Wed Feb 23 18:41:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 12757323 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D2B1C433F5 for ; Wed, 23 Feb 2022 18:41:26 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.277709.474507 (Exim 4.92) (envelope-from ) id 1nMwZe-0006xv-HS; Wed, 23 Feb 2022 18:41:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 277709.474507; Wed, 23 Feb 2022 18:41:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nMwZe-0006xo-D4; Wed, 23 Feb 2022 18:41:14 +0000 Received: by outflank-mailman (input) for mailman id 277709; Wed, 23 Feb 2022 18:41:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nMwZd-0006xi-P5 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 18:41:13 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nMwZd-0007ws-IE; Wed, 23 Feb 2022 18:41:13 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nMwZd-0001AZ-A0; Wed, 23 Feb 2022 18:41:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date: Subject:Cc:To:From; bh=gZuPgiqxjVfP/Y7/jxgEUCCMKOsAyvpkD31FqQ8FjqY=; b=A6rgHd bgozl/Q+QTO+Qdv5ULWSn4GQSesSUxGCc07L8ClPm5WD/WmnBitB52UhZokGC2vxq5MuuMWqj88z9 /j958oQYcw2xBZaF3J5u8tbcGRy9bNykbTPLj86avjTDO/jI6RH4HLVQACV4BPqPqsz0U4BxCgZTf WD5P16IigGA=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu Subject: [PATCH] xen/mm: pg_offlined can be defined as bool in free_heap_pages() Date: Wed, 23 Feb 2022 18:41:10 +0000 Message-Id: <20220223184110.7941-1-julien@xen.org> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 From: Julien Grall The local variable pg_offlined in free_heap_pages() can only take two values. So switch it to a bool. Signed-off-by: Julien Grall --- xen/common/page_alloc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index e971bf91e0be..72e6cac2365d 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -1437,8 +1437,9 @@ static void free_heap_pages( { unsigned long mask; mfn_t mfn = page_to_mfn(pg); - unsigned int i, node = phys_to_nid(mfn_to_maddr(mfn)), pg_offlined = 0; + unsigned int i, node = phys_to_nid(mfn_to_maddr(mfn)); unsigned int zone = page_to_zone(pg); + bool pg_offlined = true; ASSERT(order <= MAX_ORDER); @@ -1447,7 +1448,7 @@ static void free_heap_pages( for ( i = 0; i < (1 << order); i++ ) { if ( mark_page_free(&pg[i], mfn_add(mfn, i)) ) - pg_offlined = 1; + pg_offlined = true; if ( need_scrub ) {