diff mbox series

[2/4] livepatch: improve rune for fetching of Build ID

Message ID 20220302142711.38953-3-roger.pau@citrix.com (mailing list archive)
State New, archived
Headers show
Series livepatch: fixes for patch generation | expand

Commit Message

Roger Pau Monné March 2, 2022, 2:27 p.m. UTC
The current one is broken with my version of readelf and returns
'NT_GNU_BUILD_ID'.

Signed-off-by: Roger Pau Monné <roger.pau@citrrix.com>
---
 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Doebel, Bjoern March 2, 2022, 3:33 p.m. UTC | #1
The current one is broken with my version of readelf and returns
    'NT_GNU_BUILD_ID'.

    Signed-off-by: Roger Pau Monné <roger.pau@citrrix.com>
    ---
     README.md | 2 +-
     1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/README.md b/README.md
    index b48a3df..948a7de 100644
    --- a/README.md
    +++ b/README.md
    @@ -16,7 +16,7 @@ $ cp -r ~/src/xen ~/src/xenbuild
     $ cd ~/src/xen/xen
     $ make nconfig # Make sure to set CONFIG_LIVEPATCH=y
     $ make
    -$ BUILDID=$(readelf -Wn xen-syms | awk '/Build ID:/ {print $3}')
    +$ BUILDID=$(readelf -Wn xen-syms | sed -n -e 's/^.*Build ID: //p')
     ```

     Next, build a live patch, using a patch and the source, build ID, and
 

Reviewed-by: Bjoern Doebel <doebel@amazon.de>




Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879
Ross Lagerwall March 8, 2022, 1:47 p.m. UTC | #2
> From: Roger Pau Monne <roger.pau@citrix.com>
> Sent: Wednesday, March 2, 2022 2:27 PM
> To: xen-devel@lists.xenproject.org <xen-devel@lists.xenproject.org>
> Cc: Ross Lagerwall <ross.lagerwall@citrix.com>; konrad.wilk@oracle.com <konrad.wilk@oracle.com>; doebel@amazon.de <doebel@amazon.de>; julien@xen.org <julien@xen.org>; Andrew Cooper <Andrew.Cooper3@citrix.com>; Roger Pau Monne <roger.pau@citrix.com>; Roger Pau Monné <roger.pau@citrrix.com>
> Subject: [PATCH 2/4] livepatch: improve rune for fetching of Build ID 
>  
> The current one is broken with my version of readelf and returns
> 'NT_GNU_BUILD_ID'.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrrix.com>
> ---
>  README.md | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/README.md b/README.md
> index b48a3df..948a7de 100644
> --- a/README.md
> +++ b/README.md
> @@ -16,7 +16,7 @@ $ cp -r ~/src/xen ~/src/xenbuild
>  $ cd ~/src/xen/xen
>  $ make nconfig # Make sure to set CONFIG_LIVEPATCH=y
>  $ make
> -$ BUILDID=$(readelf -Wn xen-syms | awk '/Build ID:/ {print $3}')
> +$ BUILDID=$(readelf -Wn xen-syms | sed -n -e 's/^.*Build ID: //p')
>  ```
>  
>  Next, build a live patch, using a patch and the source, build ID, and
> -- 
> 2.34.1

Reviewed-by: Ross Lagerwall <ross.lagerwall@citrix.com>
diff mbox series

Patch

diff --git a/README.md b/README.md
index b48a3df..948a7de 100644
--- a/README.md
+++ b/README.md
@@ -16,7 +16,7 @@  $ cp -r ~/src/xen ~/src/xenbuild
 $ cd ~/src/xen/xen
 $ make nconfig # Make sure to set CONFIG_LIVEPATCH=y
 $ make
-$ BUILDID=$(readelf -Wn xen-syms | awk '/Build ID:/ {print $3}')
+$ BUILDID=$(readelf -Wn xen-syms | sed -n -e 's/^.*Build ID: //p')
 ```
 
 Next, build a live patch, using a patch and the source, build ID, and