diff mbox series

[31/36] Disable coloring if static memory support is selected

Message ID 20220304174701.1453977-32-marco.solieri@minervasys.tech (mailing list archive)
State New, archived
Headers show
Series Arm cache coloring | expand

Commit Message

Marco Solieri March 4, 2022, 5:46 p.m. UTC 
From: Luca Miccio <lucmiccio@gmail.com>

Static memory assumes to have physically contiguous memory mapped to
domains. This assumption cannot be made when coloring is enabled.
These two features have to be mutually exclusive.

Signed-off-by: Luca Miccio <lucmiccio@gmail.com>
---
 xen/arch/arm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Julien Grall March 14, 2022, 8:04 p.m. UTC | #1 
Hi Marco,

On 04/03/2022 17:46, Marco Solieri wrote:
> From: Luca Miccio <lucmiccio@gmail.com>
> 
> Static memory assumes to have physically contiguous memory mapped to
> domains. This assumption cannot be made when coloring is enabled.
> These two features have to be mutually exclusive.

I understand that at runtime, you want them to be mutually exclusive.
But I am not sure to understand why this needs to be mutually exclusive 
at compile time.

In fact, I think it would be nice if we have a same binary Xen that can 
be used with/without coloring. Could you outline any reasons that would 
make this goal difficult to achieve?

Cheers,
diff mbox series

Patch

diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
index f0f999d172..8f8be9d754 100644
--- a/xen/arch/arm/Kconfig
+++ b/xen/arch/arm/Kconfig
@@ -100,6 +100,7 @@  config HARDEN_BRANCH_PREDICTOR
 config COLORING
 	bool "L2 cache coloring"
 	default n
+	depends on !STATIC_MEMORY
 	depends on ARM_64
 
 config TEE