From patchwork Mon Mar 14 07:05:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: jianchunfu X-Patchwork-Id: 12779605 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84B0EC433F5 for ; Mon, 14 Mar 2022 07:11:36 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.289920.491623 (Exim 4.92) (envelope-from ) id 1nTerD-0001P6-HV; Mon, 14 Mar 2022 07:11:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 289920.491623; Mon, 14 Mar 2022 07:11:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nTerD-0001Oz-EY; Mon, 14 Mar 2022 07:11:07 +0000 Received: by outflank-mailman (input) for mailman id 289920; Mon, 14 Mar 2022 07:05:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nTem5-0000Vn-9H for xen-devel@lists.xenproject.org; Mon, 14 Mar 2022 07:05:49 +0000 Received: from cmccmta1.chinamobile.com (cmccmta1.chinamobile.com [221.176.66.79]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 25d4dfc0-a365-11ec-853b-5f4723681683; Mon, 14 Mar 2022 08:05:44 +0100 (CET) Received: from spf.mail.chinamobile.com (unknown[172.16.121.3]) by rmmx-syy-dmz-app02-12002 (RichMail) with SMTP id 2ee2622ee9422a3-edaed; Mon, 14 Mar 2022 15:05:38 +0800 (CST) Received: from localhost.localdomain (unknown[223.108.79.97]) by rmsmtp-syy-appsvr02-12002 (RichMail) with SMTP id 2ee2622ee93bb5a-76513; Mon, 14 Mar 2022 15:05:37 +0800 (CST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 25d4dfc0-a365-11ec-853b-5f4723681683 X-RM-TRANSID: 2ee2622ee9422a3-edaed X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 X-RM-TRANSID: 2ee2622ee93bb5a-76513 From: jianchunfu To: tglx@linutronix.de Cc: x86@kernel.org, hpa@zytor.com, boris.ostrovsky@oracle.com, sstabellini@kernel.org, xen-devel@lists.xenproject.org, trivial@kernel.org, jianchunfu Subject: [PATCH] arch:x86:xen: Remove unnecessary assignment in xen_apic_read() Date: Mon, 14 Mar 2022 15:05:14 +0800 Message-Id: <20220314070514.2602-1-jianchunfu@cmss.chinamobile.com> X-Mailer: git-send-email 2.18.4 In the function xen_apic_read(), the initialized value of 'ret' is unused because it will be assigned by the function HYPERVISOR_platform_op(), thus remove it. Signed-off-by: jianchunfu Reviewed-by: Boris Ostrovsky --- arch/x86/xen/apic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/xen/apic.c b/arch/x86/xen/apic.c index 0d46cc283..62d34b661 100644 --- a/arch/x86/xen/apic.c +++ b/arch/x86/xen/apic.c @@ -51,7 +51,7 @@ static u32 xen_apic_read(u32 reg) .interface_version = XENPF_INTERFACE_VERSION, .u.pcpu_info.xen_cpuid = 0, }; - int ret = 0; + int ret; /* Shouldn't need this as APIC is turned off for PV, and we only * get called on the bootup processor. But just in case. */