diff mbox series

x86/mwait-idle: add missing newline

Message ID 20220516103601.25671-1-roger.pau@citrix.com (mailing list archive)
State New, archived
Headers show
Series x86/mwait-idle: add missing newline | expand

Commit Message

Roger Pau Monné May 16, 2022, 10:36 a.m. UTC 
Fixes: 5a211704e8 ('mwait-idle: prevent SKL-H boot failure when C8+C9+C10 enabled')
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 xen/arch/x86/cpu/mwait-idle.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andrew Cooper May 16, 2022, 10:54 a.m. UTC | #1 
On 16/05/2022 11:36, Roger Pau Monne wrote:
> Fixes: 5a211704e8 ('mwait-idle: prevent SKL-H boot failure when C8+C9+C10 enabled')
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
Jan Beulich May 17, 2022, 2:29 p.m. UTC | #2 
On 16.05.2022 12:36, Roger Pau Monne wrote:
> Fixes: 5a211704e8 ('mwait-idle: prevent SKL-H boot failure when C8+C9+C10 enabled')
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks for spotting. I wonder whether we shouldn't mention the Linux
commit (654d08a42a56) which did this as a "side effect". Obviously
the fix here isn't really a port thereof.

Jan

> --- a/xen/arch/x86/cpu/mwait-idle.c
> +++ b/xen/arch/x86/cpu/mwait-idle.c
> @@ -1363,7 +1363,7 @@ static int cf_check mwait_idle_cpu_init(
>  		/* if state marked as disabled, skip it */
>  		if (cpuidle_state_table[cstate].flags &
>  		    CPUIDLE_FLAG_DISABLED) {
> -			printk(XENLOG_DEBUG PREFIX "state %s is disabled",
> +			printk(XENLOG_DEBUG PREFIX "state %s is disabled\n",
>  			       cpuidle_state_table[cstate].name);
>  			continue;
>  		}
diff mbox series

Patch

diff --git a/xen/arch/x86/cpu/mwait-idle.c b/xen/arch/x86/cpu/mwait-idle.c
index 6add64dc5f..5d77672f6b 100644
--- a/xen/arch/x86/cpu/mwait-idle.c
+++ b/xen/arch/x86/cpu/mwait-idle.c
@@ -1363,7 +1363,7 @@  static int cf_check mwait_idle_cpu_init(
 		/* if state marked as disabled, skip it */
 		if (cpuidle_state_table[cstate].flags &
 		    CPUIDLE_FLAG_DISABLED) {
-			printk(XENLOG_DEBUG PREFIX "state %s is disabled",
+			printk(XENLOG_DEBUG PREFIX "state %s is disabled\n",
 			       cpuidle_state_table[cstate].name);
 			continue;
 		}