| Message ID | 20220530113459.20124-1-jgross@suse.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0c293fbd7b1be5ff05760352a5f7644425c465d2 |
| Headers | show |
| Series | xen/netback: fix incorrect usage of RING_HAS_UNCONSUMED_REQUESTS() | expand |
On 30.05.2022 13:34, Juergen Gross wrote: > Commit 6fac592cca60 ("xen: update ring.h") missed to fix one use case > of RING_HAS_UNCONSUMED_REQUESTS(). > > Reported-by: Jan Beulich <jbeulich@suse.com> > Fixes: 6fac592cca60 ("xen: update ring.h") > Signed-off-by: Juergen Gross <jgross@suse.com> Reviewed-by: Jan Beulich <jbeulich@suse.com>
On Mon, May 30, 2022 at 01:34:59PM +0200, Juergen Gross wrote: > Commit 6fac592cca60 ("xen: update ring.h") missed to fix one use case > of RING_HAS_UNCONSUMED_REQUESTS(). > > Reported-by: Jan Beulich <jbeulich@suse.com> > Fixes: 6fac592cca60 ("xen: update ring.h") > Signed-off-by: Juergen Gross <jgross@suse.com> Acked-by: Wei Liu <wei.liu@kernel.org>
Hello: This patch was applied to netdev/net.git (master) by Paolo Abeni <pabeni@redhat.com>: On Mon, 30 May 2022 13:34:59 +0200 you wrote: > Commit 6fac592cca60 ("xen: update ring.h") missed to fix one use case > of RING_HAS_UNCONSUMED_REQUESTS(). > > Reported-by: Jan Beulich <jbeulich@suse.com> > Fixes: 6fac592cca60 ("xen: update ring.h") > Signed-off-by: Juergen Gross <jgross@suse.com> > > [...] Here is the summary with links: - xen/netback: fix incorrect usage of RING_HAS_UNCONSUMED_REQUESTS() https://git.kernel.org/netdev/net/c/09e545f73814 You are awesome, thank you!
diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 0f7fd159f0f2..d93814c14a23 100644 --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c @@ -828,7 +828,7 @@ static void xenvif_tx_build_gops(struct xenvif_queue *queue, break; } - work_to_do = RING_HAS_UNCONSUMED_REQUESTS(&queue->tx); + work_to_do = XEN_RING_NR_UNCONSUMED_REQUESTS(&queue->tx); if (!work_to_do) break;
Commit 6fac592cca60 ("xen: update ring.h") missed to fix one use case of RING_HAS_UNCONSUMED_REQUESTS(). Reported-by: Jan Beulich <jbeulich@suse.com> Fixes: 6fac592cca60 ("xen: update ring.h") Signed-off-by: Juergen Gross <jgross@suse.com> --- drivers/net/xen-netback/netback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)