| Message ID | 20220610083358.101412-3-michal.orzel@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | small fixes | expand |
Hi, On 10/06/2022 09:33, Michal Orzel wrote: > ... to gicv2_map_hwdom_extra_mappings as the former clearly contains > a typo. > > Fixes: 86b93e00c0b6 ("xen/arm: gicv2: Export GICv2m register frames to Dom0 by device tree" NIT: In general, fixes tag are used for bug (i.e. Xen would not function properly without it and likely need backports). Even if the name is incorrect, there is no bug here. So my preference is to drop this tag. Other than that: Acked-by; Julien Grall <jgrall@amazon.com> Cheers,
Hi Julien, On 10.06.2022 11:07, Julien Grall wrote: > Hi, > > On 10/06/2022 09:33, Michal Orzel wrote: >> ... to gicv2_map_hwdom_extra_mappings as the former clearly contains >> a typo. >> >> Fixes: 86b93e00c0b6 ("xen/arm: gicv2: Export GICv2m register frames to Dom0 by device tree" > > NIT: In general, fixes tag are used for bug (i.e. Xen would not function properly without it and likely need backports). Even if the name is incorrect, there is no bug here. So my preference is to drop this tag. > Thanks, I will keep it in mind. > Other than that: > > Acked-by; Julien Grall <jgrall@amazon.com> NIT: s/;/: > > Cheers, > Cheers, Michal
diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c index 2cc2f6bc18..bd773bcc67 100644 --- a/xen/arch/arm/gic-v2.c +++ b/xen/arch/arm/gic-v2.c @@ -679,7 +679,7 @@ static void gicv2_irq_set_affinity(struct irq_desc *desc, const cpumask_t *cpu_m spin_unlock(&gicv2.lock); } -static int gicv2_map_hwdown_extra_mappings(struct domain *d) +static int gicv2_map_hwdom_extra_mappings(struct domain *d) { const struct v2m_data *v2m_data; @@ -1352,7 +1352,7 @@ const static struct gic_hw_operations gicv2_ops = { .make_hwdom_madt = gicv2_make_hwdom_madt, .get_hwdom_extra_madt_size = gicv2_get_hwdom_extra_madt_size, #endif - .map_hwdom_extra_mappings = gicv2_map_hwdown_extra_mappings, + .map_hwdom_extra_mappings = gicv2_map_hwdom_extra_mappings, .iomem_deny_access = gicv2_iomem_deny_access, .do_LPI = gicv2_do_LPI, };
... to gicv2_map_hwdom_extra_mappings as the former clearly contains a typo. Fixes: 86b93e00c0b6 ("xen/arm: gicv2: Export GICv2m register frames to Dom0 by device tree") Signed-off-by: Michal Orzel <michal.orzel@arm.com> --- xen/arch/arm/gic-v2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)