| Message ID | 20220626211131.678995-5-burzalodowa@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Fix MISRA C 2012 violations | expand |
On 26.06.2022 23:11, Xenia Ragiadakou wrote: > The per-cpu variable last_tickle_cpu is referenced only in credit.c. > Change its linkage from external to internal by adding the storage-class > specifier static to its definitions. > > This patch aims to resolve indirectly a MISRA C 2012 Rule 8.4 violation warning. > > Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Reviewed-by: Jan Beulich <jbeulich@suse.com> (again with the same remark as on patch 2)
On Mon, 27 Jun 2022, Xenia Ragiadakou wrote: > The per-cpu variable last_tickle_cpu is referenced only in credit.c. > Change its linkage from external to internal by adding the storage-class > specifier static to its definitions. > > This patch aims to resolve indirectly a MISRA C 2012 Rule 8.4 violation warning. > > Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> > --- > xen/common/sched/credit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/common/sched/credit.c b/xen/common/sched/credit.c > index 4d3bd8cba6..47945c2834 100644 > --- a/xen/common/sched/credit.c > +++ b/xen/common/sched/credit.c > @@ -348,7 +348,7 @@ static void burn_credits(struct csched_unit *svc, s_time_t now) > static bool __read_mostly opt_tickle_one_idle = true; > boolean_param("tickle_one_idle_cpu", opt_tickle_one_idle); > > -DEFINE_PER_CPU(unsigned int, last_tickle_cpu); > +static DEFINE_PER_CPU(unsigned int, last_tickle_cpu); > > static inline void __runq_tickle(const struct csched_unit *new) > { > -- > 2.34.1 > >
diff --git a/xen/common/sched/credit.c b/xen/common/sched/credit.c index 4d3bd8cba6..47945c2834 100644 --- a/xen/common/sched/credit.c +++ b/xen/common/sched/credit.c @@ -348,7 +348,7 @@ static void burn_credits(struct csched_unit *svc, s_time_t now) static bool __read_mostly opt_tickle_one_idle = true; boolean_param("tickle_one_idle_cpu", opt_tickle_one_idle); -DEFINE_PER_CPU(unsigned int, last_tickle_cpu); +static DEFINE_PER_CPU(unsigned int, last_tickle_cpu); static inline void __runq_tickle(const struct csched_unit *new) {
The per-cpu variable last_tickle_cpu is referenced only in credit.c. Change its linkage from external to internal by adding the storage-class specifier static to its definitions. This patch aims to resolve indirectly a MISRA C 2012 Rule 8.4 violation warning. Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> --- xen/common/sched/credit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)