Message ID | 20220718071825.22113-2-andrew.cooper3@citrix.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | xen/wait: Improvements | expand |
On 18.07.2022 09:18, Andrew Cooper wrote: > The preservation of entry_vector was introduced with ecf9846a6a20 ("x86: > save/restore only partial register state where possible") where > TRAP_regs_partial was introduced, but missed from f9eb74789af7 ("x86/entry: > Remove support for partial cpu_user_regs frames") where TRAP_regs_partial was > removed. > > Fixes: f9eb74789af7 ("x86/entry: Remove support for partial cpu_user_regs frames") > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> Reviewed-by: Jan Beulich <jbeulich@suse.com>
diff --git a/xen/common/wait.c b/xen/common/wait.c index 9276d76464fb..3ebb884fe738 100644 --- a/xen/common/wait.c +++ b/xen/common/wait.c @@ -124,7 +124,6 @@ static void __prepare_to_wait(struct waitqueue_vcpu *wqv) struct cpu_info *cpu_info = get_cpu_info(); struct vcpu *curr = current; unsigned long dummy; - u32 entry_vector = cpu_info->guest_cpu_user_regs.entry_vector; ASSERT(wqv->esp == 0); @@ -169,8 +168,6 @@ static void __prepare_to_wait(struct waitqueue_vcpu *wqv) for ( ; ; ) do_softirq(); } - - cpu_info->guest_cpu_user_regs.entry_vector = entry_vector; } static void __finish_wait(struct waitqueue_vcpu *wqv)
The preservation of entry_vector was introduced with ecf9846a6a20 ("x86: save/restore only partial register state where possible") where TRAP_regs_partial was introduced, but missed from f9eb74789af7 ("x86/entry: Remove support for partial cpu_user_regs frames") where TRAP_regs_partial was removed. Fixes: f9eb74789af7 ("x86/entry: Remove support for partial cpu_user_regs frames") Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> --- CC: Jan Beulich <JBeulich@suse.com> CC: Roger Pau Monné <roger.pau@citrix.com> CC: Wei Liu <wl@xen.org> --- xen/common/wait.c | 3 --- 1 file changed, 3 deletions(-)