| Message ID | 20220817152106.56601-1-anthony.perard@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [XEN] build: Fix missing MAKEFLAGS --no-print-directory | expand |
On 17/08/2022 16:21, Anthony Perard wrote: > While we already have "--no-print-directory" added to the make flags > in some cases, there's one case where the flags is missing, when doing > an out-of-tree build with O=, e.g. > cd xen; make O=build > > Without it, we just have loads of "Entering directory" and "Leaving > directory" with the same directory. > > The comment and location in the Makefile are copied from Linux. > > Reported-by: Andrew Cooper <andrew.cooper3@citrix.com> > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
On 17.08.2022 17:21, Anthony PERARD wrote: > While we already have "--no-print-directory" added to the make flags > in some cases, there's one case where the flags is missing, when doing > an out-of-tree build with O=, e.g. > cd xen; make O=build > > Without it, we just have loads of "Entering directory" and "Leaving > directory" with the same directory. > > The comment and location in the Makefile are copied from Linux. > > Reported-by: Andrew Cooper <andrew.cooper3@citrix.com> > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> Acked-by: Jan Beulich <jbeulich@suse.com>
diff --git a/xen/Makefile b/xen/Makefile index 69b4dc960f..106aff6a07 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -186,6 +186,11 @@ endif # root-make-done # We process the rest of the Makefile if this is the final invocation of make ifeq ($(need-sub-make),) +# Do not print "Entering directory ...", +# but we want to display it when entering to the output directory +# so that IDEs/editors are able to understand relative filenames. +MAKEFLAGS += --no-print-directory + ifeq ($(abs_srctree),$(abs_objtree)) # building in the source tree srctree := .
While we already have "--no-print-directory" added to the make flags in some cases, there's one case where the flags is missing, when doing an out-of-tree build with O=, e.g. cd xen; make O=build Without it, we just have loads of "Entering directory" and "Leaving directory" with the same directory. The comment and location in the Makefile are copied from Linux. Reported-by: Andrew Cooper <andrew.cooper3@citrix.com> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> --- xen/Makefile | 5 +++++ 1 file changed, 5 insertions(+)