diff mbox series

[ImageBuilder] Update README.md

Message ID 20220912115918.19496-1-michal.orzel@amd.com (mailing list archive)
State Accepted
Headers show
Series [ImageBuilder] Update README.md | expand

Commit Message

Michal Orzel Sept. 12, 2022, 11:59 a.m. UTC
Get rid of references to XEN_PASSTHROUGH_PATHS, as there is no such option
and it should be replaced with DOMU_PASSTHROUGH_PATHS[number].

Update PASSTHROUGH_DTS_REPO example. The directory storing partial device
trees is now device-trees-2021.2/zcu102 instead of device-trees-2021.2.

Signed-off-by: Michal Orzel <michal.orzel@amd.com>
---
 README.md | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Ayan Kumar Halder Sept. 12, 2022, 4:20 p.m. UTC | #1
On 12/09/2022 12:59, Michal Orzel wrote:
> Get rid of references to XEN_PASSTHROUGH_PATHS, as there is no such option
> and it should be replaced with DOMU_PASSTHROUGH_PATHS[number].
>
> Update PASSTHROUGH_DTS_REPO example. The directory storing partial device
> trees is now device-trees-2021.2/zcu102 instead of device-trees-2021.2.
>
> Signed-off-by: Michal Orzel <michal.orzel@amd.com>
Reviewed-by: Ayan Kumar Halder <ayankuma@amd.com>
> ---
>   README.md | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/README.md b/README.md
> index 041818349954..da9ba788a3bf 100644
> --- a/README.md
> +++ b/README.md
> @@ -34,7 +34,7 @@ BOOT_CMD="booti"
>   DEVICE_TREE="mpsoc.dtb"
>   XEN="xen"
>   XEN_CMD="console=dtuart dtuart=serial0 dom0_mem=1G dom0_max_vcpus=1 bootscrub=0 vwfi=native sched=null"
> -PASSTHROUGH_DTS_REPO="git@github.com:Xilinx/xen-passthrough-device-trees.git device-trees-2021.2"
> +PASSTHROUGH_DTS_REPO="git@github.com:Xilinx/xen-passthrough-device-trees.git device-trees-2021.2/zcu102"
>   DOM0_KERNEL="Image-dom0"
>   DOM0_CMD="console=hvc0 earlycon=xen earlyprintk=xen clk_ignore_unused"
>   DOM0_RAMDISK="dom0-ramdisk.cpio"
> @@ -99,9 +99,9 @@ Where:
>   
>   - PASSTHROUGH_DTS_REPO specifies the git repository and/or the directory
>     which contains the partial device trees. This is optional. However, if
> -  this is specified, then XEN_PASSTHROUGH_PATHS need to be specified.
> +  this is specified, then DOMU_PASSTHROUGH_PATHS[number] need to be specified.
>     uboot-script-gen will compile the partial device trees which have
> -  been specified in XEN_PASSTHROUGH_PATHS.
> +  been specified in DOMU_PASSTHROUGH_PATHS[number].
>   
>   - DOM0_KERNEL specifies the Dom0 kernel file to load.
>     For dom0less configurations, the parameter is optional.
Stefano Stabellini Sept. 13, 2022, 12:51 a.m. UTC | #2
On Mon, 12 Sep 2022, Ayan Kumar Halder wrote:
> On 12/09/2022 12:59, Michal Orzel wrote:
> > Get rid of references to XEN_PASSTHROUGH_PATHS, as there is no such option
> > and it should be replaced with DOMU_PASSTHROUGH_PATHS[number].
> > 
> > Update PASSTHROUGH_DTS_REPO example. The directory storing partial device
> > trees is now device-trees-2021.2/zcu102 instead of device-trees-2021.2.
> > 
> > Signed-off-by: Michal Orzel <michal.orzel@amd.com>
> Reviewed-by: Ayan Kumar Halder <ayankuma@amd.com>

Acked-by: Stefano Stabellini <sstabellini@kernel.org>


> > ---
> >   README.md | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/README.md b/README.md
> > index 041818349954..da9ba788a3bf 100644
> > --- a/README.md
> > +++ b/README.md
> > @@ -34,7 +34,7 @@ BOOT_CMD="booti"
> >   DEVICE_TREE="mpsoc.dtb"
> >   XEN="xen"
> >   XEN_CMD="console=dtuart dtuart=serial0 dom0_mem=1G dom0_max_vcpus=1
> > bootscrub=0 vwfi=native sched=null"
> > 
> > -PASSTHROUGH_DTS_REPO="git@github.com:Xilinx/xen-passthrough-device-trees.git
> > device-trees-2021.2"
> > +PASSTHROUGH_DTS_REPO="git@github.com:Xilinx/xen-passthrough-device-trees.git
> > device-trees-2021.2/zcu102"
> >   DOM0_KERNEL="Image-dom0"
> >   DOM0_CMD="console=hvc0 earlycon=xen earlyprintk=xen clk_ignore_unused"
> >   DOM0_RAMDISK="dom0-ramdisk.cpio"
> > @@ -99,9 +99,9 @@ Where:
> >     - PASSTHROUGH_DTS_REPO specifies the git repository and/or the directory
> >     which contains the partial device trees. This is optional. However, if
> > -  this is specified, then XEN_PASSTHROUGH_PATHS need to be specified.
> > +  this is specified, then DOMU_PASSTHROUGH_PATHS[number] need to be
> > specified.
> >     uboot-script-gen will compile the partial device trees which have
> > -  been specified in XEN_PASSTHROUGH_PATHS.
> > +  been specified in DOMU_PASSTHROUGH_PATHS[number].
> >     - DOM0_KERNEL specifies the Dom0 kernel file to load.
> >     For dom0less configurations, the parameter is optional.
>
diff mbox series

Patch

diff --git a/README.md b/README.md
index 041818349954..da9ba788a3bf 100644
--- a/README.md
+++ b/README.md
@@ -34,7 +34,7 @@  BOOT_CMD="booti"
 DEVICE_TREE="mpsoc.dtb"
 XEN="xen"
 XEN_CMD="console=dtuart dtuart=serial0 dom0_mem=1G dom0_max_vcpus=1 bootscrub=0 vwfi=native sched=null"
-PASSTHROUGH_DTS_REPO="git@github.com:Xilinx/xen-passthrough-device-trees.git device-trees-2021.2"
+PASSTHROUGH_DTS_REPO="git@github.com:Xilinx/xen-passthrough-device-trees.git device-trees-2021.2/zcu102"
 DOM0_KERNEL="Image-dom0"
 DOM0_CMD="console=hvc0 earlycon=xen earlyprintk=xen clk_ignore_unused"
 DOM0_RAMDISK="dom0-ramdisk.cpio"
@@ -99,9 +99,9 @@  Where:
 
 - PASSTHROUGH_DTS_REPO specifies the git repository and/or the directory
   which contains the partial device trees. This is optional. However, if
-  this is specified, then XEN_PASSTHROUGH_PATHS need to be specified.
+  this is specified, then DOMU_PASSTHROUGH_PATHS[number] need to be specified.
   uboot-script-gen will compile the partial device trees which have
-  been specified in XEN_PASSTHROUGH_PATHS.
+  been specified in DOMU_PASSTHROUGH_PATHS[number].
 
 - DOM0_KERNEL specifies the Dom0 kernel file to load.
   For dom0less configurations, the parameter is optional.