Message ID | 20221012182552.26866-2-andrew.cooper3@citrix.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | Ocaml stub fixes | expand |
Hi Andrew, > -----Original Message----- > From: Andrew Cooper <andrew.cooper3@citrix.com> > Subject: [PATCH 1/2] tools/ocaml/xc: Fix code legibility in > stub_xc_domain_create() > > Reposition the defines to match the outer style and to make the logic > half-legible. > > No functional change. > > Fixes: 0570d7f276dd ("x86/msr: introduce an option for compatible MSR > behavior selection") > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> Release-acked-by: Henry Wang <Henry.Wang@arm.com> Kind regards, Henry
diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c index 19335bdf4572..fe9c00ce008a 100644 --- a/tools/ocaml/libs/xc/xenctrl_stubs.c +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c @@ -232,22 +232,20 @@ CAMLprim value stub_xc_domain_create(value xch, value wanted_domid, value config /* Mnemonics for the named fields inside xen_x86_arch_domainconfig */ #define VAL_EMUL_FLAGS Field(arch_domconfig, 0) +#define VAL_MISC_FLAGS Field(arch_domconfig, 1) cfg.arch.emulation_flags = ocaml_list_to_c_bitmap /* ! x86_arch_emulation_flags X86_EMU_ none */ /* ! XEN_X86_EMU_ XEN_X86_EMU_ALL all */ (VAL_EMUL_FLAGS); -#undef VAL_EMUL_FLAGS - -#define VAL_MISC_FLAGS Field(arch_domconfig, 1) - cfg.arch.misc_flags = ocaml_list_to_c_bitmap /* ! x86_arch_misc_flags X86_ none */ /* ! XEN_X86_ XEN_X86_MISC_FLAGS_MAX max */ (VAL_MISC_FLAGS); #undef VAL_MISC_FLAGS +#undef VAL_EMUL_FLAGS #else caml_failwith("Unhandled: x86");
Reposition the defines to match the outer style and to make the logic half-legible. No functional change. Fixes: 0570d7f276dd ("x86/msr: introduce an option for compatible MSR behavior selection") Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> --- CC: Christian Lindig <christian.lindig@citrix.com> CC: David Scott <dave@recoil.org> CC: Edwin Torok <edvin.torok@citrix.com> CC: Rob Hoes <Rob.Hoes@citrix.com> CC: Henry Wang <Henry.Wang@arm.com> --- tools/ocaml/libs/xc/xenctrl_stubs.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)