Message ID | 20221101152842.4257-6-jgross@suse.com (mailing list archive) |
---|---|
State | Superseded |
Headers | show
Return-Path: <xen-devel-bounces@lists.xenproject.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0763FC433FE for <xen-devel@archiver.kernel.org>; Tue, 1 Nov 2022 15:29:27 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.434835.687509 (Exim 4.92) (envelope-from <xen-devel-bounces@lists.xenproject.org>) id 1optCW-0000gp-F3; Tue, 01 Nov 2022 15:29:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 434835.687509; Tue, 01 Nov 2022 15:29:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <xen-devel-bounces@lists.xenproject.org>) id 1optCW-0000ge-AL; Tue, 01 Nov 2022 15:29:16 +0000 Received: by outflank-mailman (input) for mailman id 434835; Tue, 01 Nov 2022 15:29:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <SRS0=PfM8=3B=suse.com=jgross@srs-se1.protection.inumbo.net>) id 1optCU-0007Tl-Ul for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 15:29:14 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f0e9d469-59f9-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 16:29:14 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 238181F8E3; Tue, 1 Nov 2022 15:29:14 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E1FD41346F; Tue, 1 Nov 2022 15:29:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6NvLNUk7YWOuYAAAMHmgww (envelope-from <jgross@suse.com>); Tue, 01 Nov 2022 15:29:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion <xen-devel.lists.xenproject.org> List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>, <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe> List-Post: <mailto:xen-devel@lists.xenproject.org> List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help> List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe> Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org> X-Inumbo-ID: f0e9d469-59f9-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667316554; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SuvESnVvB2BaByGaIJAGNczPYSTrohyV2ePtAUTn3Zo=; b=r5QuV7JC7wkD4s9mWUzioVvFGyOcQt6tK54cHnqZqJUEHkisMCSL2jMJCVwEf78RCBDYGI 57TyhVRZRE66CLy+U/cvO3/oR1WCLifZj34+TYcXP2GX2Lha7Y+wyW8SeDivHuo4jVimj9 mKKVe5DrQ9JKXAgd6WGdcGBdQxLYrn4= From: Juergen Gross <jgross@suse.com> To: xen-devel@lists.xenproject.org Cc: Juergen Gross <jgross@suse.com>, Wei Liu <wl@xen.org>, Julien Grall <julien@xen.org>, Anthony PERARD <anthony.perard@citrix.com> Subject: [PATCH 05/20] tools/xenstore: preserve errno across corrupt() Date: Tue, 1 Nov 2022 16:28:27 +0100 Message-Id: <20221101152842.4257-6-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101152842.4257-1-jgross@suse.com> References: <20221101152842.4257-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit |
Series |
tools/xenstore: do some cleanup and fixes
|
expand
|
Hi Juergen, On 01/11/2022 15:28, Juergen Gross wrote: > Let corrupt() preserve errno in order to be able to simplify error > handling in future. > > This is rather easy as the errno value when entering corrupt() is > saved already. > > Signed-off-by: Juergen Gross <jgross@suse.com> Reviewed-by: Julien Grall <jgrall@amazon.com> Cheers,
diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index d48208ecfe..8c2cca62b7 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -2549,6 +2549,8 @@ void corrupt(struct connection *conn, const char *fmt, ...) talloc_free(str); check_store(); + + errno = saved_errno; } #ifndef NO_SOCKETS
Let corrupt() preserve errno in order to be able to simplify error handling in future. This is rather easy as the errno value when entering corrupt() is saved already. Signed-off-by: Juergen Gross <jgross@suse.com> --- tools/xenstore/xenstored_core.c | 2 ++ 1 file changed, 2 insertions(+)