diff mbox series

[1/6] disas: add G_GNUC_PRINTF to gstring_printf

Message ID 20221219130205.687815-2-berrange@redhat.com (mailing list archive)
State New, archived
Headers show
Series enforce use of G_GNUC_PRINTF annotations | expand

Commit Message

Daniel P. Berrangé Dec. 19, 2022, 1:02 p.m. UTC 
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 disas.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Stefan Weil Dec. 19, 2022, 8:43 p.m. UTC | #1 
Am 19.12.22 um 14:02 schrieb Daniel P. Berrangé:
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>   disas.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/disas.c b/disas.c
> index 94d3b45042..31df8f5b89 100644
> --- a/disas.c
> +++ b/disas.c
> @@ -239,6 +239,7 @@ void target_disas(FILE *out, CPUState *cpu, target_ulong code,
>       }
>   }
>   
> +G_GNUC_PRINTF(2, 3)
>   static int gstring_printf(FILE *stream, const char *fmt, ...)
>   {
>       /* We abuse the FILE parameter to pass a GString. */

The current code uses a different pattern:

static RETURN_TYPE G_GNUC_PRINTF(2, 3) function(argument list)

So I would have expected

static int G_GNUC_PRINTF(2, 3)
gstring_printf(FILE *stream, const char *fmt, ...)

Does that matter? Do we care for different patterns?

Stefan
diff mbox series

Patch

diff --git a/disas.c b/disas.c
index 94d3b45042..31df8f5b89 100644
--- a/disas.c
+++ b/disas.c
@@ -239,6 +239,7 @@  void target_disas(FILE *out, CPUState *cpu, target_ulong code,
     }
 }
 
+G_GNUC_PRINTF(2, 3)
 static int gstring_printf(FILE *stream, const char *fmt, ...)
 {
     /* We abuse the FILE parameter to pass a GString. */