diff mbox series

[v2,08/13] tools/xenstore: remove unused events list

Message ID 20230330085011.9170-9-jgross@suse.com (mailing list archive)
State Superseded
Headers show
Series tools/xenstore: more cleanups | expand

Commit Message

Jürgen Groß March 30, 2023, 8:50 a.m. UTC 
struct watch contains an used struct list_head events. Remove it.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 tools/xenstore/xenstored_watch.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Julien Grall May 3, 2023, 1:08 p.m. UTC | #1 
Hi Juergen,

On 30/03/2023 09:50, Juergen Gross wrote:
> struct watch contains an used struct list_head events. Remove it.

Typo: s/used/unused/?

> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

> ---
>   tools/xenstore/xenstored_watch.c | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/tools/xenstore/xenstored_watch.c b/tools/xenstore/xenstored_watch.c
> index e8eb35de02..4195c59e17 100644
> --- a/tools/xenstore/xenstored_watch.c
> +++ b/tools/xenstore/xenstored_watch.c
> @@ -36,9 +36,6 @@ struct watch
>   	/* Watches on this connection */
>   	struct list_head list;
>   
> -	/* Current outstanding events applying to this watch. */
> -	struct list_head events;
> -
>   	/* Offset into path for skipping prefix (used for relative paths). */
>   	unsigned int prefix_len;
>   
> @@ -205,8 +202,6 @@ static struct watch *add_watch(struct connection *conn, char *path, char *token,
>   
>   	watch->prefix_len = relative ? strlen(get_implicit_path(conn)) + 1 : 0;
>   
> -	INIT_LIST_HEAD(&watch->events);
> -
>   	domain_watch_inc(conn);
>   	list_add_tail(&watch->list, &conn->watches);
>   	talloc_set_destructor(watch, destroy_watch);
Jürgen Groß May 3, 2023, 2:49 p.m. UTC | #2 
On 03.05.23 15:08, Julien Grall wrote:
> Hi Juergen,
> 
> On 30/03/2023 09:50, Juergen Gross wrote:
>> struct watch contains an used struct list_head events. Remove it.
> 
> Typo: s/used/unused/?

Yes.

> 
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
> 
> Acked-by: Julien Grall <jgrall@amazon.com>

Thanks,


Juergen
diff mbox series

Patch

diff --git a/tools/xenstore/xenstored_watch.c b/tools/xenstore/xenstored_watch.c
index e8eb35de02..4195c59e17 100644
--- a/tools/xenstore/xenstored_watch.c
+++ b/tools/xenstore/xenstored_watch.c
@@ -36,9 +36,6 @@  struct watch
 	/* Watches on this connection */
 	struct list_head list;
 
-	/* Current outstanding events applying to this watch. */
-	struct list_head events;
-
 	/* Offset into path for skipping prefix (used for relative paths). */
 	unsigned int prefix_len;
 
@@ -205,8 +202,6 @@  static struct watch *add_watch(struct connection *conn, char *path, char *token,
 
 	watch->prefix_len = relative ? strlen(get_implicit_path(conn)) + 1 : 0;
 
-	INIT_LIST_HEAD(&watch->events);
-
 	domain_watch_inc(conn);
 	list_add_tail(&watch->list, &conn->watches);
 	talloc_set_destructor(watch, destroy_watch);