| Message ID | 20230601142742.15489-3-olaf@aepfle.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | xentrace changes | expand |
Sorry for the delay here. Just a couple of notes on the whole series. First, you didn't CC me on 0/7 or 1/7. Secondly, patch 7 seems to be corrupted (see e.g., Patchew's attempt to apply the series [1]). [1] https://patchew.org/Xen/20230601142742.15489-1-olaf@aepfle.de/ -George On Thu, Jun 1, 2023 at 3:28 PM Olaf Hering <olaf@aepfle.de> wrote: > The input values were always 32bit. > > Fixes 55ee5dea32 ("xentrace: add TRC_HVM_EMUL") > > Signed-off-by: Olaf Hering <olaf@aepfle.de> > --- > tools/xentrace/formats | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/xentrace/formats b/tools/xentrace/formats > index 0fcc327a40..afb5ee0112 100644 > --- a/tools/xentrace/formats > +++ b/tools/xentrace/formats > @@ -211,8 +211,8 @@ > 0x00802008 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) do_irq [ irq = %(1)d, > began = %(2)dus, ended = %(3)dus ] > > 0x00084001 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) hpet create [ tn = %(1)d, > irq = %(2)d, delta = 0x%(4)08x%(3)08x, period = 0x%(6)08x%(5)08x ] > -0x00084002 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) pit create [ delta = > 0x%(1)016x, period = 0x%(2)016x ] > -0x00084003 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtc create [ delta = > 0x%(1)016x , period = 0x%(2)016x ] > +0x00084002 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) pit create [ delta = > 0x%(1)08x, period = 0x%(2)08x ] > +0x00084003 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtc create [ delta = > 0x%(1)08x, period = 0x%(2)08x ] > 0x00084004 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) vlapic create [ delta = > 0x%(2)08x%(1)08x , period = 0x%(4)08x%(3)08x, irq = %(5)d ] > 0x00084005 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) hpet destroy [ tn = %(1)d > ] > 0x00084006 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) pit destroy [ ] >
Fri, 28 Jul 2023 17:47:11 +0100 George Dunlap <george.dunlap@cloud.com>: > Just a couple of notes on the whole series. First, you didn't CC me on 0/7 > or 1/7. Secondly, patch 7 seems to be corrupted (see e.g., Patchew's > attempt to apply the series [1]). The cover letter can not be easily fixed, this is a bug in git send-email. It should be able to collect all recipients and put them in the cover letter. I think I already pointed that out a while ago on git-devel... I think #1 can be fixed by adjusting the MAINTAINERS file. Not sure why #7 fails to apply. I will rebase and resend next week. Olaf
On Fri, Jul 28, 2023 at 6:52 PM Olaf Hering <olaf@aepfle.de> wrote: > Fri, 28 Jul 2023 17:47:11 +0100 George Dunlap <george.dunlap@cloud.com>: > > > Just a couple of notes on the whole series. First, you didn't CC me on > 0/7 > > or 1/7. Secondly, patch 7 seems to be corrupted (see e.g., Patchew's > > attempt to apply the series [1]). > > The cover letter can not be easily fixed, this is a bug in git send-email. > It should be able to collect all recipients and put them in the cover > letter. > I think I already pointed that out a while ago on git-devel... > > I think #1 can be fixed by adjusting the MAINTAINERS file. > Not sure why #7 fails to apply. > Running `git am --show-current-patch` reveals a tail that looks like this: ``` + [EXIT_REASON_NOTIFY]=3D"NOTIFY", }; =20 ``` This may again be a known issue with `git am` and base64-encoded files: I think `mailsplit` knows how to deal with these sorts of line breaks; and `git am` also knows how to decode base64; but it does them in the wrong order, so base64-encoded mails don't get handled properly. I reported it to them several years ago [1], and nothing happened. -George [1] https://lore.kernel.org/git/c44c3958-b0eb-22bd-bc35-04982706162f@citrix.com/
On Thu, Jun 1, 2023 at 3:28 PM Olaf Hering <olaf@aepfle.de> wrote: > The input values were always 32bit. > > Fixes 55ee5dea32 ("xentrace: add TRC_HVM_EMUL") > > Signed-off-by: Olaf Hering <olaf@aepfle.de> > --- > tools/xentrace/formats | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/xentrace/formats b/tools/xentrace/formats > index 0fcc327a40..afb5ee0112 100644 > --- a/tools/xentrace/formats > +++ b/tools/xentrace/formats > @@ -211,8 +211,8 @@ > 0x00802008 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) do_irq [ irq = %(1)d, > began = %(2)dus, ended = %(3)dus ] > > 0x00084001 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) hpet create [ tn = %(1)d, > irq = %(2)d, delta = 0x%(4)08x%(3)08x, period = 0x%(6)08x%(5)08x ] > -0x00084002 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) pit create [ delta = > 0x%(1)016x, period = 0x%(2)016x ] > -0x00084003 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtc create [ delta = > 0x%(1)016x , period = 0x%(2)016x ] > +0x00084002 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) pit create [ delta = > 0x%(1)08x, period = 0x%(2)08x ] > +0x00084003 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtc create [ delta = > 0x%(1)08x, period = 0x%(2)08x ] > Looks good. While we're here, any reason not to s/create/start/; to match up with the trace definition? Either way: Reviewed-by: George Dunlap <george.dunlap@cloud.com>
diff --git a/tools/xentrace/formats b/tools/xentrace/formats index 0fcc327a40..afb5ee0112 100644 --- a/tools/xentrace/formats +++ b/tools/xentrace/formats @@ -211,8 +211,8 @@ 0x00802008 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) do_irq [ irq = %(1)d, began = %(2)dus, ended = %(3)dus ] 0x00084001 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) hpet create [ tn = %(1)d, irq = %(2)d, delta = 0x%(4)08x%(3)08x, period = 0x%(6)08x%(5)08x ] -0x00084002 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) pit create [ delta = 0x%(1)016x, period = 0x%(2)016x ] -0x00084003 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtc create [ delta = 0x%(1)016x , period = 0x%(2)016x ] +0x00084002 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) pit create [ delta = 0x%(1)08x, period = 0x%(2)08x ] +0x00084003 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtc create [ delta = 0x%(1)08x, period = 0x%(2)08x ] 0x00084004 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) vlapic create [ delta = 0x%(2)08x%(1)08x , period = 0x%(4)08x%(3)08x, irq = %(5)d ] 0x00084005 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) hpet destroy [ tn = %(1)d ] 0x00084006 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) pit destroy [ ]
The input values were always 32bit. Fixes 55ee5dea32 ("xentrace: add TRC_HVM_EMUL") Signed-off-by: Olaf Hering <olaf@aepfle.de> --- tools/xentrace/formats | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)