Message ID | 20230714132024.3091309-1-andrew.cooper3@citrix.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | xen/ACPI: Remove acpi_get_pxm() entirely | expand |
On 14.07.2023 15:20, Andrew Cooper wrote: > There are no callers, and the non-stub implementation is #if 0'd out, with the > internal trying to perform an AML invocation. > > There's no plausible way that code is getting un-#if 0'd, so drop it. > > No functional change. > > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> Acked-by: Jan Beulich <jbeulich@suse.com>
diff --git a/xen/drivers/acpi/numa.c b/xen/drivers/acpi/numa.c index bc6e888234e4..77945f874454 100644 --- a/xen/drivers/acpi/numa.c +++ b/xen/drivers/acpi/numa.c @@ -212,24 +212,3 @@ int __init acpi_numa_init(void) acpi_numa_arch_fixup(); return 0; } - -#if 0 -int acpi_get_pxm(acpi_handle h) -{ - unsigned long pxm; - acpi_status status; - acpi_handle handle; - acpi_handle phandle = h; - - do { - handle = phandle; - status = acpi_evaluate_integer(handle, "_PXM", NULL, &pxm); - if (ACPI_SUCCESS(status)) - return (int)pxm; - status = acpi_get_parent(handle, &phandle); - } while (ACPI_SUCCESS(status)); - return -1; -} - -EXPORT_SYMBOL(acpi_get_pxm); -#endif diff --git a/xen/include/xen/acpi.h b/xen/include/xen/acpi.h index 8ec95791726e..6a2f5983fdd3 100644 --- a/xen/include/xen/acpi.h +++ b/xen/include/xen/acpi.h @@ -195,15 +195,6 @@ int acpi_set_pdc_bits(uint32_t acpi_id, XEN_GUEST_HANDLE(uint32)); #endif int arch_acpi_set_pdc_bits(u32 acpi_id, u32 *, u32 mask); -#ifdef CONFIG_ACPI_NUMA -int acpi_get_pxm(acpi_handle handle); -#else -static inline int acpi_get_pxm(acpi_handle handle) -{ - return 0; -} -#endif - void acpi_reboot(void); #ifdef CONFIG_INTEL_IOMMU
There are no callers, and the non-stub implementation is #if 0'd out, with the internal trying to perform an AML invocation. There's no plausible way that code is getting un-#if 0'd, so drop it. No functional change. Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> --- CC: George Dunlap <George.Dunlap@eu.citrix.com> CC: Jan Beulich <JBeulich@suse.com> CC: Stefano Stabellini <sstabellini@kernel.org> CC: Wei Liu <wl@xen.org> CC: Julien Grall <julien@xen.org> --- xen/drivers/acpi/numa.c | 21 --------------------- xen/include/xen/acpi.h | 9 --------- 2 files changed, 30 deletions(-)