diff mbox series

[2/2] Update Xen version to 4.18-rc

Message ID 20230929075857.87092-3-julien@xen.org (mailing list archive)
State New, archived
Headers show
Series Prepare the tree for Xen 4.18 RC1 | expand

Commit Message

Julien Grall Sept. 29, 2023, 7:58 a.m. UTC
From: Julien Grall <jgrall@amazon.com>

Signed-off-by: Julien Grall <jgrall@amazon.com>
---
 README       | 16 ++++++++--------
 SUPPORT.md   |  2 +-
 xen/Makefile |  2 +-
 3 files changed, 10 insertions(+), 10 deletions(-)

Comments

Jürgen Groß Sept. 29, 2023, 8:04 a.m. UTC | #1
On 29.09.23 09:58, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
> 
> Signed-off-by: Julien Grall <jgrall@amazon.com>
> ---
>   README       | 16 ++++++++--------
>   SUPPORT.md   |  2 +-
>   xen/Makefile |  2 +-
>   3 files changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/README b/README
> index a491c8dce55b..f45e1ef1cdca 100644
> --- a/README
> +++ b/README
> @@ -1,11 +1,11 @@
> -###############################################
> -__  __            _  _    _  ___
> -\ \/ /___ _ __   | || |  / |( _ )
> - \  // _ \ '_ \  | || |_ | |/ _ \
> - /  \  __/ | | | |__   _|| | (_) |
> -/_/\_\___|_| |_|    |_|(_)_|\___/
> -
> -###############################################
> +#################################################
> +                  _  _    _  ___
> +__  _____ _ __   | || |  / |( _ )       _ __ ___
> +\ \/ / _ \ '_ \  | || |_ | |/ _ \ _____| '__/ __|
> + >  <  __/ | | | |__   _|| | (_) |_____| | | (__
> +/_/\_\___|_| |_|    |_|(_)_|\___/      |_|  \___|
> +
> +#################################################

Is it on purpose to use "xen" instead of "Xen"?


Juergen
Henry Wang Sept. 29, 2023, 8:04 a.m. UTC | #2
Hi Julien,

> On Sep 29, 2023, at 15:58, Julien Grall <julien@xen.org> wrote:
> 
> From: Julien Grall <jgrall@amazon.com>
> 
> Signed-off-by: Julien Grall <jgrall@amazon.com>

Release-acked-by: Henry Wang <Henry.Wang@arm.com>

Kind regards,
Henry

> ---
> README       | 16 ++++++++--------
> SUPPORT.md   |  2 +-
> xen/Makefile |  2 +-
> 3 files changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/README b/README
> index a491c8dce55b..f45e1ef1cdca 100644
> --- a/README
> +++ b/README
> @@ -1,11 +1,11 @@
> -###############################################
> -__  __            _  _    _  ___
> -\ \/ /___ _ __   | || |  / |( _ )
> - \  // _ \ '_ \  | || |_ | |/ _ \
> - /  \  __/ | | | |__   _|| | (_) |
> -/_/\_\___|_| |_|    |_|(_)_|\___/
> -
> -###############################################
> +#################################################
> +                  _  _    _  ___
> +__  _____ _ __   | || |  / |( _ )       _ __ ___
> +\ \/ / _ \ '_ \  | || |_ | |/ _ \ _____| '__/ __|
> + >  <  __/ | | | |__   _|| | (_) |_____| | | (__
> +/_/\_\___|_| |_|    |_|(_)_|\___/      |_|  \___|
> +
> +#################################################
> 
> https://www.xen.org/
> 
> diff --git a/SUPPORT.md b/SUPPORT.md
> index 3461f5cf2fe3..44dbd4f19040 100644
> --- a/SUPPORT.md
> +++ b/SUPPORT.md
> @@ -9,7 +9,7 @@ for the definitions of the support status levels etc.
> 
> # Release Support
> 
> -    Xen-Version: 4.18-unstable
> +    Xen-Version: 4.18-rc
>     Initial-Release: n/a
>     Supported-Until: TBD
>     Security-Support-Until: Unreleased - not yet security-supported
> diff --git a/xen/Makefile b/xen/Makefile
> index 2dc5e3526de9..fd0e63d29efb 100644
> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -6,7 +6,7 @@ this-makefile := $(call lastword,$(MAKEFILE_LIST))
> # All other places this is stored (eg. compile.h) should be autogenerated.
> export XEN_VERSION       = 4
> export XEN_SUBVERSION    = 18
> -export XEN_EXTRAVERSION ?= -unstable$(XEN_VENDORVERSION)
> +export XEN_EXTRAVERSION ?= -rc$(XEN_VENDORVERSION)
> export XEN_FULLVERSION   = $(XEN_VERSION).$(XEN_SUBVERSION)$(XEN_EXTRAVERSION)
> -include xen-version
> 
> -- 
> 2.40.1
> 
>
Julien Grall Sept. 29, 2023, 8:06 a.m. UTC | #3
Hi Juergen,

On 29/09/2023 09:04, Juergen Gross wrote:
> On 29.09.23 09:58, Julien Grall wrote:
>> From: Julien Grall <jgrall@amazon.com>
>>
>> Signed-off-by: Julien Grall <jgrall@amazon.com>
>> ---
>>   README       | 16 ++++++++--------
>>   SUPPORT.md   |  2 +-
>>   xen/Makefile |  2 +-
>>   3 files changed, 10 insertions(+), 10 deletions(-)
>>
>> diff --git a/README b/README
>> index a491c8dce55b..f45e1ef1cdca 100644
>> --- a/README
>> +++ b/README
>> @@ -1,11 +1,11 @@
>> -###############################################
>> -__  __            _  _    _  ___
>> -\ \/ /___ _ __   | || |  / |( _ )
>> - \  // _ \ '_ \  | || |_ | |/ _ \
>> - /  \  __/ | | | |__   _|| | (_) |
>> -/_/\_\___|_| |_|    |_|(_)_|\___/
>> -
>> -###############################################
>> +#################################################
>> +                  _  _    _  ___
>> +__  _____ _ __   | || |  / |( _ )       _ __ ___
>> +\ \/ / _ \ '_ \  | || |_ | |/ _ \ _____| '__/ __|
>> + >  <  __/ | | | |__   _|| | (_) |_____| | | (__
>> +/_/\_\___|_| |_|    |_|(_)_|\___/      |_|  \___|
>> +
>> +#################################################
> 
> Is it on purpose to use "xen" instead of "Xen"?

It is not, thanks for spotting. Here the new figlet:

__  __            _  _    _  ___
\ \/ /___ _ __   | || |  / |( _ )       _ __ ___
  \  // _ \ '_ \  | || |_ | |/ _ \ _____| '__/ __|
  /  \  __/ | | | |__   _|| | (_) |_____| | | (__
/_/\_\___|_| |_|    |_|(_)_|\___/      |_|  \___|

I will update the tree directly.

Cheers,
Henry Wang Sept. 29, 2023, 8:07 a.m. UTC | #4
> On Sep 29, 2023, at 16:04, Juergen Gross <jgross@suse.com> wrote:
> 
> On 29.09.23 09:58, Julien Grall wrote:
>> From: Julien Grall <jgrall@amazon.com>
>> Signed-off-by: Julien Grall <jgrall@amazon.com>
>> ---
>>  README       | 16 ++++++++--------
>>  SUPPORT.md   |  2 +-
>>  xen/Makefile |  2 +-
>>  3 files changed, 10 insertions(+), 10 deletions(-)
>> diff --git a/README b/README
>> index a491c8dce55b..f45e1ef1cdca 100644
>> --- a/README
>> +++ b/README
>> @@ -1,11 +1,11 @@
>> -###############################################
>> -__  __            _  _    _  ___
>> -\ \/ /___ _ __   | || |  / |( _ )
>> - \  // _ \ '_ \  | || |_ | |/ _ \
>> - /  \  __/ | | | |__   _|| | (_) |
>> -/_/\_\___|_| |_|    |_|(_)_|\___/
>> -
>> -###############################################
>> +#################################################
>> +                  _  _    _  ___
>> +__  _____ _ __   | || |  / |( _ )       _ __ ___
>> +\ \/ / _ \ '_ \  | || |_ | |/ _ \ _____| '__/ __|
>> + >  <  __/ | | | |__   _|| | (_) |_____| | | (__
>> +/_/\_\___|_| |_|    |_|(_)_|\___/      |_|  \___|
>> +
>> +#################################################
> 
> Is it on purpose to use "xen" instead of "Xen"?

I actually had the same question, but not sure if it really matters so didn’t
add any comments… Do we have some convention on this? So far I
have seen “xen”, “XEN” and “Xen” in different contexts.

Kind regards,
Henry

> 
> 
> Juergen
> <OpenPGP_0xB0DE9DD628BF132F.asc>
Julien Grall Oct. 2, 2023, 8:43 a.m. UTC | #5
Hi,

On 29/09/2023 09:07, Henry Wang wrote:
> 
> 
>> On Sep 29, 2023, at 16:04, Juergen Gross <jgross@suse.com> wrote:
>>
>> On 29.09.23 09:58, Julien Grall wrote:
>>> From: Julien Grall <jgrall@amazon.com>
>>> Signed-off-by: Julien Grall <jgrall@amazon.com>
>>> ---
>>>   README       | 16 ++++++++--------
>>>   SUPPORT.md   |  2 +-
>>>   xen/Makefile |  2 +-
>>>   3 files changed, 10 insertions(+), 10 deletions(-)
>>> diff --git a/README b/README
>>> index a491c8dce55b..f45e1ef1cdca 100644
>>> --- a/README
>>> +++ b/README
>>> @@ -1,11 +1,11 @@
>>> -###############################################
>>> -__  __            _  _    _  ___
>>> -\ \/ /___ _ __   | || |  / |( _ )
>>> - \  // _ \ '_ \  | || |_ | |/ _ \
>>> - /  \  __/ | | | |__   _|| | (_) |
>>> -/_/\_\___|_| |_|    |_|(_)_|\___/
>>> -
>>> -###############################################
>>> +#################################################
>>> +                  _  _    _  ___
>>> +__  _____ _ __   | || |  / |( _ )       _ __ ___
>>> +\ \/ / _ \ '_ \  | || |_ | |/ _ \ _____| '__/ __|
>>> + >  <  __/ | | | |__   _|| | (_) |_____| | | (__
>>> +/_/\_\___|_| |_|    |_|(_)_|\___/      |_|  \___|
>>> +
>>> +#################################################
>>
>> Is it on purpose to use "xen" instead of "Xen"?
> 
> I actually had the same question, but not sure if it really matters so didn’t
> add any comments… Do we have some convention on this? So far I
> have seen “xen”, “XEN” and “Xen” in different contexts.

I don't know if there are any convention. But we usually try to keep 
consistent within the same file.

In this case, the original word was with a uppercase 'x'. So I should 
have kept as-is.

Cheers,
diff mbox series

Patch

diff --git a/README b/README
index a491c8dce55b..f45e1ef1cdca 100644
--- a/README
+++ b/README
@@ -1,11 +1,11 @@ 
-###############################################
-__  __            _  _    _  ___
-\ \/ /___ _ __   | || |  / |( _ )
- \  // _ \ '_ \  | || |_ | |/ _ \
- /  \  __/ | | | |__   _|| | (_) |
-/_/\_\___|_| |_|    |_|(_)_|\___/
-
-###############################################
+#################################################
+                  _  _    _  ___
+__  _____ _ __   | || |  / |( _ )       _ __ ___
+\ \/ / _ \ '_ \  | || |_ | |/ _ \ _____| '__/ __|
+ >  <  __/ | | | |__   _|| | (_) |_____| | | (__
+/_/\_\___|_| |_|    |_|(_)_|\___/      |_|  \___|
+
+#################################################
 
 https://www.xen.org/
 
diff --git a/SUPPORT.md b/SUPPORT.md
index 3461f5cf2fe3..44dbd4f19040 100644
--- a/SUPPORT.md
+++ b/SUPPORT.md
@@ -9,7 +9,7 @@  for the definitions of the support status levels etc.
 
 # Release Support
 
-    Xen-Version: 4.18-unstable
+    Xen-Version: 4.18-rc
     Initial-Release: n/a
     Supported-Until: TBD
     Security-Support-Until: Unreleased - not yet security-supported
diff --git a/xen/Makefile b/xen/Makefile
index 2dc5e3526de9..fd0e63d29efb 100644
--- a/xen/Makefile
+++ b/xen/Makefile
@@ -6,7 +6,7 @@  this-makefile := $(call lastword,$(MAKEFILE_LIST))
 # All other places this is stored (eg. compile.h) should be autogenerated.
 export XEN_VERSION       = 4
 export XEN_SUBVERSION    = 18
-export XEN_EXTRAVERSION ?= -unstable$(XEN_VENDORVERSION)
+export XEN_EXTRAVERSION ?= -rc$(XEN_VENDORVERSION)
 export XEN_FULLVERSION   = $(XEN_VERSION).$(XEN_SUBVERSION)$(XEN_EXTRAVERSION)
 -include xen-version