| Message ID | 20231114143816.71079-9-philmd@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/xen: Have most of Xen files become target-agnostic | expand |
On Tue, Nov 14, 2023 at 03:38:04PM +0100, Philippe Mathieu-Daudé wrote:
> All these stubs are protected by a 'if (xen_enabled())' check.
Are you sure? There's still nothing that prevent a compiler from wanting
those, I don't think.
Sure, often compilers will remove dead code in `if(0){...}`, but there's
no guaranty, is there?
Cheers,
diff --git a/stubs/xen-hw-stub.c b/stubs/xen-hw-stub.c index 6cf0e9a4c1..53c6a6f2a0 100644 --- a/stubs/xen-hw-stub.c +++ b/stubs/xen-hw-stub.c @@ -8,36 +8,12 @@ #include "qemu/osdep.h" #include "hw/xen/xen.h" -#include "hw/xen/xen-x86.h" - -int xen_pci_slot_get_pirq(PCIDevice *pci_dev, int irq_num) -{ - return -1; -} - -void xen_intx_set_irq(void *opaque, int irq_num, int level) -{ -} - -int xen_set_pci_link_route(uint8_t link, uint8_t irq) -{ - return -1; -} int xen_is_pirq_msi(uint32_t msi_data) { return 0; } -qemu_irq *xen_interrupt_controller_init(void) -{ - return NULL; -} - void xen_register_framebuffer(MemoryRegion *mr) { } - -void xen_hvm_init_pc(PCMachineState *pcms, MemoryRegion **ram_memory) -{ -}
All these stubs are protected by a 'if (xen_enabled())' check. Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- stubs/xen-hw-stub.c | 24 ------------------------ 1 file changed, 24 deletions(-)