| Message ID | 20231121160358.8080-3-roger.pau@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | automation: minor fixes and improvements | expand |
On Tue, 21 Nov 2023, Roger Pau Monne wrote: > The serial is already setup by the firmware, be consistent with the rest of the > QEMU tests and don't specify a com1 setup. > > Note it's also bogus, as the extra ',' will make the intended DPS argument to > be parsed as the io-base. > > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> > --- > Changes in v2: > - New in this version > --- > automation/scripts/qemu-smoke-x86-64.sh | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/automation/scripts/qemu-smoke-x86-64.sh b/automation/scripts/qemu-smoke-x86-64.sh > index 188ff8e3d658..3014d07314b9 100755 > --- a/automation/scripts/qemu-smoke-x86-64.sh > +++ b/automation/scripts/qemu-smoke-x86-64.sh > @@ -19,8 +19,7 @@ set +e > timeout -k 1 30 \ > qemu-system-x86_64 -nographic -kernel binaries/xen \ > -initrd xtf/tests/example/$k \ > - -append "loglvl=all com1=115200,,8n1 console=com1 noreboot \ > - console_timestamps=boot $extra" \ > + -append "loglvl=all console=com1 noreboot console_timestamps=boot $extra" \ > -m 512 -monitor none -serial file:smoke.serial > set -e > grep -q 'Test result: SUCCESS' smoke.serial || exit 1 > -- > 2.42.0 >
diff --git a/automation/scripts/qemu-smoke-x86-64.sh b/automation/scripts/qemu-smoke-x86-64.sh index 188ff8e3d658..3014d07314b9 100755 --- a/automation/scripts/qemu-smoke-x86-64.sh +++ b/automation/scripts/qemu-smoke-x86-64.sh @@ -19,8 +19,7 @@ set +e timeout -k 1 30 \ qemu-system-x86_64 -nographic -kernel binaries/xen \ -initrd xtf/tests/example/$k \ - -append "loglvl=all com1=115200,,8n1 console=com1 noreboot \ - console_timestamps=boot $extra" \ + -append "loglvl=all console=com1 noreboot console_timestamps=boot $extra" \ -m 512 -monitor none -serial file:smoke.serial set -e grep -q 'Test result: SUCCESS' smoke.serial || exit 1
The serial is already setup by the firmware, be consistent with the rest of the QEMU tests and don't specify a com1 setup. Note it's also bogus, as the extra ',' will make the intended DPS argument to be parsed as the io-base. Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> --- Changes in v2: - New in this version --- automation/scripts/qemu-smoke-x86-64.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)