diff mbox series

[v2,1/3] xen/cmdline: fix printf format specifier in no_config_param()

Message ID 20240223120616.73503-2-roger.pau@citrix.com (mailing list archive)
State Superseded
Headers show
Series x86/spec: improve command line parsing | expand

Commit Message

Roger Pau Monné Feb. 23, 2024, 12:06 p.m. UTC
'*' sets the width field, which is the minimum number of characters to output,
but what we want in no_config_param() is the precision instead, which is '.*'
as it imposes a maximum limit on the output.

Fixes: 68d757df8dd2 ('x86/pv: Options to disable and/or compile out 32bit PV support')
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Changes since v1:
 - New in this version.
---
 xen/include/xen/param.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jan Beulich Feb. 26, 2024, 8:29 a.m. UTC | #1
On 23.02.2024 13:06, Roger Pau Monne wrote:
> '*' sets the width field, which is the minimum number of characters to output,
> but what we want in no_config_param() is the precision instead, which is '.*'
> as it imposes a maximum limit on the output.
> 
> Fixes: 68d757df8dd2 ('x86/pv: Options to disable and/or compile out 32bit PV support')
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>
diff mbox series

Patch

diff --git a/xen/include/xen/param.h b/xen/include/xen/param.h
index 9170455cde5c..6442a92aff8e 100644
--- a/xen/include/xen/param.h
+++ b/xen/include/xen/param.h
@@ -191,7 +191,7 @@  static inline void no_config_param(const char *cfg, const char *param,
 {
     int len = e ? ({ ASSERT(e >= s); e - s; }) : strlen(s);
 
-    printk(XENLOG_INFO "CONFIG_%s disabled - ignoring '%s=%*s' setting\n",
+    printk(XENLOG_INFO "CONFIG_%s disabled - ignoring '%s=%.*s' setting\n",
            cfg, param, len, s);
 }