diff mbox series

[2/2] automation: introduce non debug clang based tests

Message ID 20240229095529.17723-3-roger.pau@citrix.com (mailing list archive)
State New, archived
Headers show
Series Restrict Clang/LLVM supported versions | expand

Commit Message

Roger Pau Monné Feb. 29, 2024, 9:55 a.m. UTC
The generated code between the debug and release builds can be quite
different, as a note 2ce562b2a413 only manifested in non-debug builds due to
the usage of -O2.

Duplicate the clang based test in order to test with both debug and non-debug
Xen builds.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 automation/gitlab-ci/test.yaml | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)

Comments

Roger Pau Monné March 5, 2024, 5:29 p.m. UTC | #1
FWIW, this is not tied to patch 1, so can go in independently.  I
think it's a worthwhile improvement.

Thanks, Roger.

On Thu, Feb 29, 2024 at 10:55:29AM +0100, Roger Pau Monne wrote:
> The generated code between the debug and release builds can be quite
> different, as a note 2ce562b2a413 only manifested in non-debug builds due to
> the usage of -O2.
> 
> Duplicate the clang based test in order to test with both debug and non-debug
> Xen builds.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> ---
>  automation/gitlab-ci/test.yaml | 18 ++++++++++++++++--
>  1 file changed, 16 insertions(+), 2 deletions(-)
> 
> diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml
> index 8b7b2e4da92d..dedca794b257 100644
> --- a/automation/gitlab-ci/test.yaml
> +++ b/automation/gitlab-ci/test.yaml
> @@ -422,13 +422,20 @@ qemu-smoke-x86-64-gcc:
>    needs:
>      - debian-stretch-gcc-debug
>  
> -qemu-smoke-x86-64-clang:
> +qemu-smoke-x86-64-clang-debug:
>    extends: .qemu-x86-64
>    script:
>      - ./automation/scripts/qemu-smoke-x86-64.sh pv 2>&1 | tee ${LOGFILE}
>    needs:
>      - debian-bookworm-clang-debug
>  
> +qemu-smoke-x86-64-clang:
> +  extends: .qemu-x86-64
> +  script:
> +    - ./automation/scripts/qemu-smoke-x86-64.sh pv 2>&1 | tee ${LOGFILE}
> +  needs:
> +    - debian-bookworm-clang
> +
>  qemu-smoke-x86-64-gcc-pvh:
>    extends: .qemu-x86-64
>    script:
> @@ -436,13 +443,20 @@ qemu-smoke-x86-64-gcc-pvh:
>    needs:
>      - debian-stretch-gcc-debug
>  
> -qemu-smoke-x86-64-clang-pvh:
> +qemu-smoke-x86-64-clang-debug-pvh:
>    extends: .qemu-x86-64
>    script:
>      - ./automation/scripts/qemu-smoke-x86-64.sh pvh 2>&1 | tee ${LOGFILE}
>    needs:
>      - debian-bookworm-clang-debug
>  
> +qemu-smoke-x86-64-clang-pvh:
> +  extends: .qemu-x86-64
> +  script:
> +    - ./automation/scripts/qemu-smoke-x86-64.sh pvh 2>&1 | tee ${LOGFILE}
> +  needs:
> +    - debian-bookworm-clang
> +
>  qemu-smoke-riscv64-gcc:
>    extends: .qemu-riscv64
>    script:
> -- 
> 2.44.0
>
Stefano Stabellini March 7, 2024, 10:15 p.m. UTC | #2
On Thu, 29 Feb 2024, Roger Pau Monne wrote:
> The generated code between the debug and release builds can be quite
> different, as a note 2ce562b2a413 only manifested in non-debug builds due to
> the usage of -O2.
> 
> Duplicate the clang based test in order to test with both debug and non-debug
> Xen builds.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
diff mbox series

Patch

diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml
index 8b7b2e4da92d..dedca794b257 100644
--- a/automation/gitlab-ci/test.yaml
+++ b/automation/gitlab-ci/test.yaml
@@ -422,13 +422,20 @@  qemu-smoke-x86-64-gcc:
   needs:
     - debian-stretch-gcc-debug
 
-qemu-smoke-x86-64-clang:
+qemu-smoke-x86-64-clang-debug:
   extends: .qemu-x86-64
   script:
     - ./automation/scripts/qemu-smoke-x86-64.sh pv 2>&1 | tee ${LOGFILE}
   needs:
     - debian-bookworm-clang-debug
 
+qemu-smoke-x86-64-clang:
+  extends: .qemu-x86-64
+  script:
+    - ./automation/scripts/qemu-smoke-x86-64.sh pv 2>&1 | tee ${LOGFILE}
+  needs:
+    - debian-bookworm-clang
+
 qemu-smoke-x86-64-gcc-pvh:
   extends: .qemu-x86-64
   script:
@@ -436,13 +443,20 @@  qemu-smoke-x86-64-gcc-pvh:
   needs:
     - debian-stretch-gcc-debug
 
-qemu-smoke-x86-64-clang-pvh:
+qemu-smoke-x86-64-clang-debug-pvh:
   extends: .qemu-x86-64
   script:
     - ./automation/scripts/qemu-smoke-x86-64.sh pvh 2>&1 | tee ${LOGFILE}
   needs:
     - debian-bookworm-clang-debug
 
+qemu-smoke-x86-64-clang-pvh:
+  extends: .qemu-x86-64
+  script:
+    - ./automation/scripts/qemu-smoke-x86-64.sh pvh 2>&1 | tee ${LOGFILE}
+  needs:
+    - debian-bookworm-clang
+
 qemu-smoke-riscv64-gcc:
   extends: .qemu-riscv64
   script: