diff mbox series

[2/2] char: lpuart: Drop useless variables from UART structure

Message ID 20240404075143.25304-3-michal.orzel@amd.com (mailing list archive)
State New
Headers show
Series drivers: char: simple cleanup | expand

Commit Message

Michal Orzel April 4, 2024, 7:51 a.m. UTC 
These variables are useless. They are being assigned a value which is
never used since UART is expected to be pre-configured.

No functional change.

Signed-off-by: Michal Orzel <michal.orzel@amd.com>
---
 xen/drivers/char/imx-lpuart.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Stefano Stabellini April 4, 2024, 9:48 p.m. UTC | #1 
On Thu, 4 Apr 2024, Michal Orzel wrote:
> These variables are useless. They are being assigned a value which is
> never used since UART is expected to be pre-configured.
> 
> No functional change.
> 
> Signed-off-by: Michal Orzel <michal.orzel@amd.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
diff mbox series

Patch

diff --git a/xen/drivers/char/imx-lpuart.c b/xen/drivers/char/imx-lpuart.c
index faf4693b66e1..7770d158bf59 100644
--- a/xen/drivers/char/imx-lpuart.c
+++ b/xen/drivers/char/imx-lpuart.c
@@ -30,7 +30,6 @@ 
 #define imx_lpuart_write(uart, off, val) writel((val), (uart)->regs + (off))
 
 static struct imx_lpuart {
-    uint32_t baud, clock_hz, data_bits, parity, stop_bits, fifo_size;
     uint32_t irq;
     char __iomem *regs;
     struct irqaction irqaction;
@@ -197,11 +196,6 @@  static int __init imx_lpuart_init(struct dt_device_node *dev,
 
     uart = &imx8_com;
 
-    uart->baud = 115200;
-    uart->data_bits = 8;
-    uart->parity = 0;
-    uart->stop_bits = 1;
-
     res = dt_device_get_paddr(dev, 0, &addr, &size);
     if ( res )
     {