| Message ID | 20240410193531.1499128-1-andrew.cooper3@citrix.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | xen/spinlock: Adjust LOCK_DEBUG_INITVAL to placate MISRA | expand |
> On 10 Apr 2024, at 20:35, Andrew Cooper <andrew.cooper3@citrix.com> wrote: > > Resolves an R7.2 violation. > > Fixes: c286bb93d20c ("xen/spinlock: support higher number of cpus") > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> Yes makes sense Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>
On Wed, 10 Apr 2024, Andrew Cooper wrote: > Resolves an R7.2 violation. > > Fixes: c286bb93d20c ("xen/spinlock: support higher number of cpus") > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
On 2024-04-10 21:35, Andrew Cooper wrote: > Resolves an R7.2 violation. > Thanks, I was going to suggest the same change. This will resolve the failure of the CI MISRA analysis on GitLab. Reviewed-by: Nicola Vetrini <nicola.vetrini@bugseng.com> > Fixes: c286bb93d20c ("xen/spinlock: support higher number of cpus") > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> > --- > CC: George Dunlap <George.Dunlap@citrix.com> > CC: Jan Beulich <JBeulich@suse.com> > CC: Stefano Stabellini <sstabellini@kernel.org> > CC: Julien Grall <julien@xen.org> > CC: Juergen Gross <jgross@suse.com> > CC: consulting@bugseng.com <consulting@bugseng.com> > CC: Roberto Bagnara <roberto.bagnara@bugseng.com> > CC: Federico Serafini <federico.serafini@bugseng.com> > CC: Nicola Vetrini <nicola.vetrini@bugseng.com> > --- > xen/include/xen/spinlock.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/include/xen/spinlock.h b/xen/include/xen/spinlock.h > index db00a24646bd..18793c5e29cb 100644 > --- a/xen/include/xen/spinlock.h > +++ b/xen/include/xen/spinlock.h > @@ -13,7 +13,7 @@ > #ifdef CONFIG_DEBUG_LOCKS > union lock_debug { > uint32_t val; > -#define LOCK_DEBUG_INITVAL 0xffffffff > +#define LOCK_DEBUG_INITVAL 0xffffffffU > struct { > unsigned int cpu:SPINLOCK_CPU_BITS; > #define LOCK_DEBUG_PAD_BITS (30 - SPINLOCK_CPU_BITS) > > base-commit: 0e7ea8ca5fc9bce9248414f6aaf2dc861abd45d9 > prerequisite-patch-id: 8d06e56c5d8a52f1387e1f5a7fce6a94b8c4a1ed > prerequisite-patch-id: 13355d26254b979c79de456c9a6ea6a9c639ba63
diff --git a/xen/include/xen/spinlock.h b/xen/include/xen/spinlock.h index db00a24646bd..18793c5e29cb 100644 --- a/xen/include/xen/spinlock.h +++ b/xen/include/xen/spinlock.h @@ -13,7 +13,7 @@ #ifdef CONFIG_DEBUG_LOCKS union lock_debug { uint32_t val; -#define LOCK_DEBUG_INITVAL 0xffffffff +#define LOCK_DEBUG_INITVAL 0xffffffffU struct { unsigned int cpu:SPINLOCK_CPU_BITS; #define LOCK_DEBUG_PAD_BITS (30 - SPINLOCK_CPU_BITS)
Resolves an R7.2 violation. Fixes: c286bb93d20c ("xen/spinlock: support higher number of cpus") Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> --- CC: George Dunlap <George.Dunlap@citrix.com> CC: Jan Beulich <JBeulich@suse.com> CC: Stefano Stabellini <sstabellini@kernel.org> CC: Julien Grall <julien@xen.org> CC: Juergen Gross <jgross@suse.com> CC: consulting@bugseng.com <consulting@bugseng.com> CC: Roberto Bagnara <roberto.bagnara@bugseng.com> CC: Federico Serafini <federico.serafini@bugseng.com> CC: Nicola Vetrini <nicola.vetrini@bugseng.com> --- xen/include/xen/spinlock.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 0e7ea8ca5fc9bce9248414f6aaf2dc861abd45d9 prerequisite-patch-id: 8d06e56c5d8a52f1387e1f5a7fce6a94b8c4a1ed prerequisite-patch-id: 13355d26254b979c79de456c9a6ea6a9c639ba63