| Message ID | 20240425091249.2639809-1-george.dunlap@cloud.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | svm: Fix MISRA 8.2 violation | expand |
On 25.04.2024 11:12, George Dunlap wrote: > Misra 8.2 requires named parameters in prototypes. Use the name from > the implementaiton. > > Fixes 0d19d3aab0 ("svm/nestedsvm: Introduce nested capabilities bit"). > > Signed-off-by: George Dunlap <george.dunlap@cloud.com> Acked-by: Jan Beulich <jbeulich@suse.com>
On 25/04/2024 10:12 am, George Dunlap wrote: > Misra 8.2 requires named parameters in prototypes. Use the name from > the implementaiton. > > Fixes 0d19d3aab0 ("svm/nestedsvm: Introduce nested capabilities bit"). Nit. We treat Fixes: as a tag. Also you might want to include the Reported-by's. Otherwise, Acked-by: Andrew Cooper <andrew.cooper3@citrix.com> although I have a strong wish to shorten the parameter name. That can be done at a later point. ~Andrew
On Thu, Apr 25, 2024 at 5:00 PM Andrew Cooper <andrew.cooper3@citrix.com> wrote: > > On 25/04/2024 10:12 am, George Dunlap wrote: > > Misra 8.2 requires named parameters in prototypes. Use the name from > > the implementaiton. > > > > Fixes 0d19d3aab0 ("svm/nestedsvm: Introduce nested capabilities bit"). > > Nit. We treat Fixes: as a tag. Oops -- I'll fix that on check-in. Gmail is also underlining my misspelling of "implementation" in red, so I'll fix that as well. > Also you might want to include the Reported-by's. I thought about adding a Reported-by; but this was reported by Eclair, which is run automatically, right? We typically don't give a "Reported-by" to the person who flagged up the osstest or gitlab failure, so I figured this would be similar. I'm happy to give credit where it's due, however. You were the first one who reported it to me, but Nicola also raised it; and I guess it's someone else who's paying for the Eclair runs. So what "Reported-by" did you have in mind? > Otherwise, Acked-by: Andrew Cooper <andrew.cooper3@citrix.com> although > I have a strong wish to shorten the parameter name. That can be done at > a later point. Thanks, -George
diff --git a/xen/arch/x86/include/asm/hvm/nestedhvm.h b/xen/arch/x86/include/asm/hvm/nestedhvm.h index 0568acb25f..ea2c1bc328 100644 --- a/xen/arch/x86/include/asm/hvm/nestedhvm.h +++ b/xen/arch/x86/include/asm/hvm/nestedhvm.h @@ -83,7 +83,7 @@ static inline bool vvmcx_valid(const struct vcpu *v) } -void start_nested_svm(struct hvm_function_table *); -void start_nested_vmx(struct hvm_function_table *); +void start_nested_svm(struct hvm_function_table *hvm_function_table); +void start_nested_vmx(struct hvm_function_table *hvm_function_table); #endif /* _HVM_NESTEDHVM_H */
Misra 8.2 requires named parameters in prototypes. Use the name from the implementaiton. Fixes 0d19d3aab0 ("svm/nestedsvm: Introduce nested capabilities bit"). Signed-off-by: George Dunlap <george.dunlap@cloud.com> --- CC: Andrew Cooper <andrew.cooper3@citrix.com> CC: Jan Beulich <jbeulich@suse.com> CC: Roger Pau Monne <roger.pau@cloud.com> CC: Nicola Vetrini <nicola.vetrini@bugseng.com> --- xen/arch/x86/include/asm/hvm/nestedhvm.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)