| Message ID | 20240502132136.532-1-jgross@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | tools/tests: don't let test-xenstore write nodes exceeding default size | expand |
On 02/05/2024 2:21 pm, Juergen Gross wrote: > Today test-xenstore will write nodes with 3000 bytes node data. This > size is exceeding the default quota for the allowed node size. While > working in dom0 with C-xenstored, OCAML-xenstored does not like that. > > Use a size of 2000 instead, which is lower than the allowed default > node size of 2048. > > Fixes: 3afc5e4a5b75 ("tools/tests: add xenstore testing framework") > Signed-off-by: Juergen Gross <jgross@suse.com> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com> Thanks for figuring this out. I'll give this and the return code fix a spin through XenRT and check there's nothing else unexpected hiding.
On 02/05/2024 2:25 pm, Andrew Cooper wrote: > On 02/05/2024 2:21 pm, Juergen Gross wrote: >> Today test-xenstore will write nodes with 3000 bytes node data. This >> size is exceeding the default quota for the allowed node size. While >> working in dom0 with C-xenstored, OCAML-xenstored does not like that. >> >> Use a size of 2000 instead, which is lower than the allowed default >> node size of 2048. >> >> Fixes: 3afc5e4a5b75 ("tools/tests: add xenstore testing framework") >> Signed-off-by: Juergen Gross <jgross@suse.com> > Acked-by: Andrew Cooper <andrew.cooper3@citrix.com> > > Thanks for figuring this out. I'll give this and the return code fix a > spin through XenRT and check there's nothing else unexpected hiding. All seems happy. I'll put these in in due course. ~Andrew
diff --git a/tools/tests/xenstore/test-xenstore.c b/tools/tests/xenstore/test-xenstore.c index d7d44cc0fa..7a9bd9afb3 100644 --- a/tools/tests/xenstore/test-xenstore.c +++ b/tools/tests/xenstore/test-xenstore.c @@ -408,9 +408,9 @@ static int test_ta3_deinit(uintptr_t par) #define TEST(s, f, p, l) { s, f ## _init, f, f ## _deinit, (uintptr_t)(p), l } struct test tests[] = { TEST("read 1", test_read, 1, "Read node with 1 byte data"), -TEST("read 3000", test_read, 3000, "Read node with 3000 bytes data"), +TEST("read 2000", test_read, 2000, "Read node with 2000 bytes data"), TEST("write 1", test_write, 1, "Write node with 1 byte data"), -TEST("write 3000", test_write, 3000, "Write node with 3000 bytes data"), +TEST("write 2000", test_write, 2000, "Write node with 2000 bytes data"), TEST("dir", test_dir, 0, "List directory"), TEST("rm node", test_rm, 0, "Remove single node"), TEST("rm dir", test_rm, WRITE_BUFFERS_N, "Remove node with sub-nodes"),
Today test-xenstore will write nodes with 3000 bytes node data. This size is exceeding the default quota for the allowed node size. While working in dom0 with C-xenstored, OCAML-xenstored does not like that. Use a size of 2000 instead, which is lower than the allowed default node size of 2048. Fixes: 3afc5e4a5b75 ("tools/tests: add xenstore testing framework") Signed-off-by: Juergen Gross <jgross@suse.com> --- tools/tests/xenstore/test-xenstore.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)