| Message ID | 20240523074040.1611264-2-xin.wang2@amd.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Remaining patches for dynamic node programming using overlay dtbo | expand |
On Thu, 23 May 2024, Henry Wang wrote: > Fix the name mismatch in the xl dt-overlay command, the > command name should be "dt-overlay" instead of "dt_overlay". > Add the missing "," in the cmdtable. > > Fix the exit code of the dt-overlay command, use EXIT_FAILURE > instead of ERROR_FAIL. > > Fixes: 61765a07e3d8 ("tools/xl: Add new xl command overlay for device tree overlay support") > Suggested-by: Anthony PERARD <anthony@xenproject.org> > Signed-off-by: Henry Wang <xin.wang2@amd.com> > Reviewed-by: Jason Andryuk <jason.andryuk@amd.com> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> > --- > v4: > - No change. > v3: > - Add Jason's Reviewed-by tag. > v2: > - New patch > --- > tools/xl/xl_cmdtable.c | 2 +- > tools/xl/xl_vmcontrol.c | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tools/xl/xl_cmdtable.c b/tools/xl/xl_cmdtable.c > index 62bdb2aeaa..1f3c6b5897 100644 > --- a/tools/xl/xl_cmdtable.c > +++ b/tools/xl/xl_cmdtable.c > @@ -635,7 +635,7 @@ const struct cmd_spec cmd_table[] = { > { "dt-overlay", > &main_dt_overlay, 0, 1, > "Add/Remove a device tree overlay", > - "add/remove <.dtbo>" > + "add/remove <.dtbo>", > "-h print this help\n" > }, > #endif > diff --git a/tools/xl/xl_vmcontrol.c b/tools/xl/xl_vmcontrol.c > index 98f6bd2e76..02575d5d36 100644 > --- a/tools/xl/xl_vmcontrol.c > +++ b/tools/xl/xl_vmcontrol.c > @@ -1278,7 +1278,7 @@ int main_dt_overlay(int argc, char **argv) > const int overlay_remove_op = 2; > > if (argc < 2) { > - help("dt_overlay"); > + help("dt-overlay"); > return EXIT_FAILURE; > } > > @@ -1302,11 +1302,11 @@ int main_dt_overlay(int argc, char **argv) > fprintf(stderr, "failed to read the overlay device tree file %s\n", > overlay_config_file); > free(overlay_dtb); > - return ERROR_FAIL; > + return EXIT_FAILURE; > } > } else { > fprintf(stderr, "overlay dtbo file not provided\n"); > - return ERROR_FAIL; > + return EXIT_FAILURE; > } > > rc = libxl_dt_overlay(ctx, overlay_dtb, overlay_dtb_size, op); > -- > 2.34.1 > >
diff --git a/tools/xl/xl_cmdtable.c b/tools/xl/xl_cmdtable.c index 62bdb2aeaa..1f3c6b5897 100644 --- a/tools/xl/xl_cmdtable.c +++ b/tools/xl/xl_cmdtable.c @@ -635,7 +635,7 @@ const struct cmd_spec cmd_table[] = { { "dt-overlay", &main_dt_overlay, 0, 1, "Add/Remove a device tree overlay", - "add/remove <.dtbo>" + "add/remove <.dtbo>", "-h print this help\n" }, #endif diff --git a/tools/xl/xl_vmcontrol.c b/tools/xl/xl_vmcontrol.c index 98f6bd2e76..02575d5d36 100644 --- a/tools/xl/xl_vmcontrol.c +++ b/tools/xl/xl_vmcontrol.c @@ -1278,7 +1278,7 @@ int main_dt_overlay(int argc, char **argv) const int overlay_remove_op = 2; if (argc < 2) { - help("dt_overlay"); + help("dt-overlay"); return EXIT_FAILURE; } @@ -1302,11 +1302,11 @@ int main_dt_overlay(int argc, char **argv) fprintf(stderr, "failed to read the overlay device tree file %s\n", overlay_config_file); free(overlay_dtb); - return ERROR_FAIL; + return EXIT_FAILURE; } } else { fprintf(stderr, "overlay dtbo file not provided\n"); - return ERROR_FAIL; + return EXIT_FAILURE; } rc = libxl_dt_overlay(ctx, overlay_dtb, overlay_dtb_size, op);
Fix the name mismatch in the xl dt-overlay command, the command name should be "dt-overlay" instead of "dt_overlay". Add the missing "," in the cmdtable. Fix the exit code of the dt-overlay command, use EXIT_FAILURE instead of ERROR_FAIL. Fixes: 61765a07e3d8 ("tools/xl: Add new xl command overlay for device tree overlay support") Suggested-by: Anthony PERARD <anthony@xenproject.org> Signed-off-by: Henry Wang <xin.wang2@amd.com> Reviewed-by: Jason Andryuk <jason.andryuk@amd.com> --- v4: - No change. v3: - Add Jason's Reviewed-by tag. v2: - New patch --- tools/xl/xl_cmdtable.c | 2 +- tools/xl/xl_vmcontrol.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-)