| Message ID | 20240903085311.49818-1-anthony.perard@vates.tech (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [XEN] CHANGELOG: Update after fixing dm_restrict | expand |
On 03.09.2024 10:54, Anthony PERARD wrote: > --- a/CHANGELOG.md > +++ b/CHANGELOG.md > @@ -16,6 +16,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) > - On x86: > - Support for running on Xeon Phi processors. > > +### Fixed > + - Fixed xl/libxl dm\_restrict feature with QEMU 9.0. > + > + > ## [4.19.0](https://xenbits.xenproject.org/gitweb/?p=xen.git;a=shortlog;h=RELEASE-4.19.0) - 2024-07-29 > > ### Changed We had no "### Fixed" so far, and I think we also shouldn't gain any. Imo this wants expressing in term of "### Changed", also wording the text accordingly (needing to adapt to qemu changes isn't a bug fix, strictly speaking, but more an enhancement in my view). Jan
On Tue, Sep 03, 2024 at 11:20:37AM +0200, Jan Beulich wrote: > On 03.09.2024 10:54, Anthony PERARD wrote: > > --- a/CHANGELOG.md > > +++ b/CHANGELOG.md > > @@ -16,6 +16,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) > > - On x86: > > - Support for running on Xeon Phi processors. > > > > +### Fixed > > + - Fixed xl/libxl dm\_restrict feature with QEMU 9.0. > > + > > + > > ## [4.19.0](https://xenbits.xenproject.org/gitweb/?p=xen.git;a=shortlog;h=RELEASE-4.19.0) - 2024-07-29 > > > > ### Changed > > We had no "### Fixed" so far, and I think we also shouldn't gain any. Imo > this wants expressing in term of "### Changed", also wording the text > accordingly (needing to adapt to qemu changes isn't a bug fix, strictly > speaking, but more an enhancement in my view). From our CHANGELOG.md: > The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) following the link, there is: > Types of changes > > - `Added` for new features. > - `Changed` for changes in existing functionality. > - `Deprecated` for soon-to-be removed features. > - `Removed` for now removed features. > - `Fixed` for any bug fixes. > - `Security` in case of vulnerabilities. So, are we not following keepachangelog.com format? Is there another document/email/discussion describing which category are allowed? Been compatible with newer version of dependencies doesn't feels like an existing functionality have changed. It feels more like a fix to the bug "can't start guest with newer QEMU". Thanks,
On 03.09.2024 12:04, Anthony PERARD wrote: > On Tue, Sep 03, 2024 at 11:20:37AM +0200, Jan Beulich wrote: >> On 03.09.2024 10:54, Anthony PERARD wrote: >>> --- a/CHANGELOG.md >>> +++ b/CHANGELOG.md >>> @@ -16,6 +16,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) >>> - On x86: >>> - Support for running on Xeon Phi processors. >>> >>> +### Fixed >>> + - Fixed xl/libxl dm\_restrict feature with QEMU 9.0. >>> + >>> + >>> ## [4.19.0](https://xenbits.xenproject.org/gitweb/?p=xen.git;a=shortlog;h=RELEASE-4.19.0) - 2024-07-29 >>> >>> ### Changed >> >> We had no "### Fixed" so far, and I think we also shouldn't gain any. Imo >> this wants expressing in term of "### Changed", also wording the text >> accordingly (needing to adapt to qemu changes isn't a bug fix, strictly >> speaking, but more an enhancement in my view). > > From our CHANGELOG.md: >> The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) > > following the link, there is: > >> Types of changes >> >> - `Added` for new features. >> - `Changed` for changes in existing functionality. >> - `Deprecated` for soon-to-be removed features. >> - `Removed` for now removed features. >> - `Fixed` for any bug fixes. >> - `Security` in case of vulnerabilities. > > So, are we not following keepachangelog.com format? Is there another > document/email/discussion describing which category are allowed? Hmm, the absence of an Fixes section made me assume such isn't supposed to there; I'm sorry. > Been compatible with newer version of dependencies doesn't feels like an > existing functionality have changed. It feels more like a fix to the bug > "can't start guest with newer QEMU". We clearly disagree here. FTAOD I don't mean to NAK such a change though, it's just that I also wouldn't ACK it. Jan
diff --git a/CHANGELOG.md b/CHANGELOG.md index 5521ae5bb3..fb9a66c727 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - On x86: - Support for running on Xeon Phi processors. +### Fixed + - Fixed xl/libxl dm\_restrict feature with QEMU 9.0. + + ## [4.19.0](https://xenbits.xenproject.org/gitweb/?p=xen.git;a=shortlog;h=RELEASE-4.19.0) - 2024-07-29 ### Changed
Fixed by change 82335a8cc54c ("libxl: Probe QEMU for -run-with chroot=dir and use it"). Signed-off-by: Anthony PERARD <anthony.perard@vates.tech> --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+)