diff mbox series

[v4,2/2] x86/boot: Add missing __XEN__ definition

Message ID 20240909132216.128114-2-frediano.ziglio@cloud.com (mailing list archive)
State New
Headers show
Series [v4,1/2] x86/boot: Optimise 32 bit C source code | expand

Commit Message

Frediano Ziglio Sept. 9, 2024, 1:22 p.m. UTC
We are compiling Xen source code so we should define __XEN__ macro.
We don't want to import all definitions from XEN_CFLAGS (as done for
other options) because most of them are processor dependent and
do not apply to 32 bit.

Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
---
 xen/arch/x86/boot/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
Changes since v3:
- improve commit message.

Comments

Andrew Cooper Sept. 9, 2024, 1:47 p.m. UTC | #1
On 09/09/2024 2:22 pm, Frediano Ziglio wrote:
> We are compiling Xen source code so we should define __XEN__ macro.
> We don't want to import all definitions from XEN_CFLAGS (as done for
> other options) because most of them are processor dependent and
> do not apply to 32 bit.
>
> Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>

Both Acked-by: Andrew Cooper <andrew.cooper3@citrix.com> and queued.
diff mbox series

Patch

diff --git a/xen/arch/x86/boot/Makefile b/xen/arch/x86/boot/Makefile
index dfe3cb7034..ff0f965876 100644
--- a/xen/arch/x86/boot/Makefile
+++ b/xen/arch/x86/boot/Makefile
@@ -15,7 +15,7 @@  CFLAGS_x86_32 := $(subst -m64,-m32 -march=i686,$(XEN_TREEWIDE_CFLAGS))
 $(call cc-options-add,CFLAGS_x86_32,CC,$(EMBEDDED_EXTRA_CFLAGS))
 CFLAGS_x86_32 += -Werror -fno-builtin -g0 -msoft-float -mregparm=3
 CFLAGS_x86_32 += -nostdinc -include $(filter %/include/xen/config.h,$(XEN_CFLAGS))
-CFLAGS_x86_32 += $(filter -I% -O%,$(XEN_CFLAGS))
+CFLAGS_x86_32 += $(filter -I% -O%,$(XEN_CFLAGS)) -D__XEN__
 
 # override for 32bit binaries
 $(head-bin-objs): CFLAGS_stack_boundary :=