diff mbox series

[v1,4/5] xen/arm: Enable early printk for S32CC via LINFlexD UART

Message ID 20240910143411.178704-5-andrei.cherechesu@oss.nxp.com (mailing list archive)
State Superseded
Headers show
Series xen/arm: Add support for S32CC platforms and LINFlexD UART | expand

Commit Message

Andrei Cherechesu Sept. 10, 2024, 2:34 p.m. UTC
From: Andrei Cherechesu <andrei.cherechesu@nxp.com>

Enabled the support for debug through early printk on S32CC
platforms via the NXP LINFlexD UART driver.

Signed-off-by: Andrei Cherechesu <andrei.cherechesu@nxp.com>
---
 xen/arch/arm/Kconfig.debug | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Julien Grall Sept. 10, 2024, 10:12 p.m. UTC | #1
Hi,

On 10/09/2024 15:34, Andrei Cherechesu (OSS) wrote:
> From: Andrei Cherechesu <andrei.cherechesu@nxp.com>
> 
> Enabled the support for debug through early printk on S32CC

NIT: We tend to avoid using past tense when describing the change. So 
s/Enabled/Enable/. However...

> platforms via the NXP LINFlexD UART driver.
> 
> Signed-off-by: Andrei Cherechesu <andrei.cherechesu@nxp.com>
> ---
>   xen/arch/arm/Kconfig.debug | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/xen/arch/arm/Kconfig.debug b/xen/arch/arm/Kconfig.debug
> index a309f67f90..9725f4193c 100644
> --- a/xen/arch/arm/Kconfig.debug
> +++ b/xen/arch/arm/Kconfig.debug
> @@ -168,6 +168,9 @@ choice
>   	config EARLY_PRINTK_RCAR3
>   		bool "Early printk with SCIF2 on Renesas R-Car Gen3 processors"
>   		select EARLY_UART_SCIF
> +	config EARLY_PRINTK_S32CC
> +		bool "Early printk with NXP LINFlexD UART on NXP S32CC processors"
> +		select EARLY_UART_LINFLEX

... we stopped adding platform specific early printk a while ago because 
this is not scalable.

Instead, we prefer to write a page in [1] which will provide all the 
information how to setup and debug Xen on a SoC (could be one per family).

Cheers,

[1] https://wiki.xenproject.org/wiki/Xen_ARM_with_Virtualization_Extensions
diff mbox series

Patch

diff --git a/xen/arch/arm/Kconfig.debug b/xen/arch/arm/Kconfig.debug
index a309f67f90..9725f4193c 100644
--- a/xen/arch/arm/Kconfig.debug
+++ b/xen/arch/arm/Kconfig.debug
@@ -168,6 +168,9 @@  choice
 	config EARLY_PRINTK_RCAR3
 		bool "Early printk with SCIF2 on Renesas R-Car Gen3 processors"
 		select EARLY_UART_SCIF
+	config EARLY_PRINTK_S32CC
+		bool "Early printk with NXP LINFlexD UART on NXP S32CC processors"
+		select EARLY_UART_LINFLEX
 	config EARLY_PRINTK_SEATTLE
 		bool "Early printk with pl011 for AMD Seattle processor"
 		select EARLY_UART_PL011
@@ -243,6 +246,7 @@  config EARLY_UART_BASE_ADDRESS
 	default 0xd0012000 if EARLY_PRINTK_MVEBU
 	default 0x48020000 if EARLY_PRINTK_OMAP5432
 	default 0xe6e88000 if EARLY_PRINTK_RCAR3
+	default 0x401c8000 if EARLY_PRINTK_S32CC
 	default 0xe1010000 if EARLY_PRINTK_SEATTLE
 	default 0x01c28000 if EARLY_PRINTK_SUN6I
 	default 0x01c28000 if EARLY_PRINTK_SUN7I