| Message ID | 20241202194107.105119-5-afd@ti.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Switch more ARM plats to sys-off handler API | expand |
Hi Andrew, On Mon, Dec 2, 2024 at 10:41 PM Andrew Davis <afd@ti.com> wrote: > > Kernel now supports chained power-off handlers. Use > register_platform_power_off() that registers a platform level power-off > handler. Legacy pm_power_off() will be removed once all drivers and archs > are converted to the new sys-off API. > > Signed-off-by: Andrew Davis <afd@ti.com> > --- > arch/arm/mach-vt8500/vt8500.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-vt8500/vt8500.c b/arch/arm/mach-vt8500/vt8500.c > index 0ab40087ae1cc..1d294255d7083 100644 > --- a/arch/arm/mach-vt8500/vt8500.c > +++ b/arch/arm/mach-vt8500/vt8500.c > @@ -141,7 +141,7 @@ static void __init vt8500_init(void) > pr_err("%s:ioremap(power_off) failed\n", __func__); > } > if (pmc_base) > - pm_power_off = &vt8500_power_off; > + register_platform_power_off(vt8500_power_off); This really calls for a separate tiny driver under drivers/power to remove the legacy single-register remapping higher up in this function... Pending that: Acked-by: Alexey Charkov <alchark@gmail.com> Best regards, Alexey
diff --git a/arch/arm/mach-vt8500/vt8500.c b/arch/arm/mach-vt8500/vt8500.c index 0ab40087ae1cc..1d294255d7083 100644 --- a/arch/arm/mach-vt8500/vt8500.c +++ b/arch/arm/mach-vt8500/vt8500.c @@ -141,7 +141,7 @@ static void __init vt8500_init(void) pr_err("%s:ioremap(power_off) failed\n", __func__); } if (pmc_base) - pm_power_off = &vt8500_power_off; + register_platform_power_off(vt8500_power_off); else pr_err("%s: PMC Hibernation register could not be remapped, not enabling power off!\n", __func__); }
Kernel now supports chained power-off handlers. Use register_platform_power_off() that registers a platform level power-off handler. Legacy pm_power_off() will be removed once all drivers and archs are converted to the new sys-off API. Signed-off-by: Andrew Davis <afd@ti.com> --- arch/arm/mach-vt8500/vt8500.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)